SpecialTranslate: Translating to qqq causes JS error data.validation is undefined
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 10 2020, 5:11 PM

Description

Summary

Translating to qqq (message documentation) causes JS error,

Uncaught TypeError: data.validation is undefined

Steps to reproduce

Visit https://www.mediawiki.org/w/index.php?title=Special:Translate/page-Template:PD_Help_Page&action=translate&task=view&group=page-Template%3APD+Help+Page&language=qqq&filter=%21translated
Type "assasa" into Template:PD Help Page translation editor
See console

QA plan

After deployment, try typing into the text editor when translating to qqq.
Review the response from translationcheck API call when translating to qqq. It should have the errors and warnings property set to an empty array.

Details

	Subject	Repo	Branch	Lines +/-
	ApiTranslationCheck: Remove empty validation response from API	mediawiki/extensions/Translate	master	+7 -4

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 10 2020, 5:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2020, 5:11 PM

Jdlrobson added a project: Wikimedia-production-error.Jul 10 2020, 5:11 PM

Umherirrender added a project: JavaScript.Jul 10 2020, 8:17 PM

abi_ claimed this task.Jul 13 2020, 10:36 AM

abi_ triaged this task as Medium priority.

abi_ moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.

abi_ added a project: Language-Team (Language-2020-Focus-Sprint).

Change 612177 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] ApiTranslationCheck: Remove empty validation response from API

https://gerrit.wikimedia.org/r/612177

gerritbot added a project: Patch-For-Review.Jul 13 2020, 10:47 AM

abi_ renamed this task from data.validation is undefined to Translating to qqq causes JS error data.validation is undefined.Jul 13 2020, 10:51 AM

abi_ updated the task description. (Show Details)

abi_ moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.

abi_ renamed this task from Translating to qqq causes JS error data.validation is undefined to SpecialTranslate: Translating to qqq causes JS error data.validation is undefined.Jul 13 2020, 2:22 PM

abi_ updated the task description. (Show Details)

Change 612177 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] ApiTranslationCheck: Remove empty validation response from API

https://gerrit.wikimedia.org/r/612177

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 7:01 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 7:10 AM

jeena moved this task from Untriaged to Jul 2020 on the Wikimedia-production-error board.Jul 15 2020, 6:27 PM

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-Focus-Sprint) board.Jul 16 2020, 5:30 AM