Page MenuHomePhabricator
Create Task
Maniphest T250897

Ensure *.entitytypes.php only defines callbacks for existing keys
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Replace EntityTypeDefinitions string literals with constantsmediawiki/extensions/WikibaseCirrusSearchmaster+7 -6
Replace EntityTypeDefinitions string literals with constantsmediawiki/extensions/WikibaseMediaInfomaster+24 -23
Replace EntityTypeDefinitions string literals with constantsmediawiki/extensions/WikibaseLexememaster+56 -54
Replace EntityTypeDefinitions string literals with constantsmediawiki/extensions/Wikibasemaster+167 -126
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Apr 22 2020, 9:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2020, 9:57 AM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 22 2020, 9:58 AM
gerritbot added a comment.Apr 23 2020, 11:13 AM

Change 592258 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/592258

gerritbot added a project: Patch-For-Review.Apr 23 2020, 11:13 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 23 2020, 3:40 PM
gerritbot added a comment.Apr 29 2020, 9:21 AM

Change 592258 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/592258

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 10:10 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 29 2020, 11:28 AM
gerritbot added a comment.Apr 30 2020, 9:43 AM

Change 593469 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593469

gerritbot added a project: Patch-For-Review.Apr 30 2020, 9:43 AM
gerritbot added a comment.Apr 30 2020, 2:48 PM

Change 593469 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593469

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2020, 3:10 PM
gerritbot added a comment.Apr 30 2020, 3:45 PM

Change 593551 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseMediaInfo@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593551

gerritbot added a project: Patch-For-Review.Apr 30 2020, 3:45 PM
gerritbot added a comment.Apr 30 2020, 4:00 PM

Change 593554 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseCirrusSearch@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593554

gerritbot added a comment.May 5 2020, 12:21 PM

Change 593551 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593551

gerritbot added a comment.May 18 2020, 3:50 PM

Change 593554 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Replace EntityTypeDefinitions string literals with constants

https://gerrit.wikimedia.org/r/593554

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 18 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 18 2020, 4:10 PM
Jakob_WMDE mentioned this in rEWCScfc653d3d754: Replace EntityTypeDefinitions string literals with constants.May 18 2020, 4:42 PM
Aklapper added a comment.Jul 27 2020, 4:27 AM

@Jakob_WMDE: Should the stask status here be "resolved"? Asking as this open tasks has no active project tags. Thanks.

Aklapper added a comment.Aug 17 2020, 8:31 AM

@Jakob_WMDE: Should the stask status here be "resolved"? Asking as this open tasks has no active project tags. Thanks.

Aklapper edited projects, added Wikibase - Federated Properties (Sprint 6/6 (Hike 2)); removed Wikibase - Federated Properties (Sprint 4/6 (Hike 1)).Sep 14 2020, 8:28 AM

No replies hence boldly adding active project tag. Feel free to correct.

Jakob_WMDE closed this task as Resolved.Sep 14 2020, 8:30 AM

Sorry. This can be considered resolved, I think.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits