Page MenuHomePhabricator
Create Task
Maniphest T249421

Hard deprecate AuthManager::singleton and remove a release later
Closed, ResolvedPublic
Actions

Description

AuthManager::singleton is only used in fallback code for older versions and could be hard deprecated.
https://codesearch.wmflabs.org/search/?q=authmanager%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

Outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/topic:authmanager+(status:open+OR+status:merged)

Details

SubjectRepoBranchLines +/-
Remove AuthManager::singletonmediawiki/coremaster+1 -31
Hard deprecate AuthManager::singletonmediawiki/coremaster+6 -1
Customize query in gerrit

Event Timeline

Umherirrender created this task.Apr 4 2020, 3:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2020, 3:26 PM
Zabe claimed this task.Mar 7 2021, 11:50 AM
Zabe subscribed.
gerritbot added a comment.Mar 7 2021, 12:14 PM

Change 669382 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/core@master] Hard deprecate AuthManager::singleton

https://gerrit.wikimedia.org/r/669382

gerritbot added a project: Patch-For-Review.Mar 7 2021, 12:14 PM
Zabe added a project: User-Zabe.Mar 8 2021, 1:18 PM
Zabe moved this task from Backlog to Deprecation on the User-Zabe board.
gerritbot added a comment.Mar 10 2021, 9:29 PM

Change 669382 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate AuthManager::singleton

https://gerrit.wikimedia.org/r/669382

Zabe moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Mar 10 2021, 9:30 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 10 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 10 2021, 10:10 PM
gerritbot added a comment.Jun 18 2021, 9:21 PM

Change 700414 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove AuthManager::singleton

https://gerrit.wikimedia.org/r/700414

gerritbot added a project: Patch-For-Review.Jun 18 2021, 9:21 PM
gerritbot added a comment.Jun 19 2021, 11:48 PM

Change 700414 merged by jenkins-bot:

[mediawiki/core@master] Remove AuthManager::singleton

https://gerrit.wikimedia.org/r/700414

DannyS712 closed this task as Resolved.Jun 19 2021, 11:49 PM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 20 2021, 12:00 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits