Add custom summary for deleting broken redirects from Special:BrokenRedirects instead of default by MediaWiki
Closed, ResolvedPublic
Actions

Description

Steps to Reproduce:

Go in Special:BrokenRedirects
Click Delete on some result

Actual Results:
It will open Special:Delete special page in new tab and will show content was: (something) in summary.

Expected Results:
When it open Special:Delete special page, it should show Broken redirect or something simular in summary.

Details

	Subject	Repo	Branch	Lines +/-
	Don't translate `brokenredirects-delete-reason`.	translatewiki	master	+1 -0
	Add default deletion reason for deleting broken redirects.	mediawiki/core	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: T239012: Remove autogeneration of Deletion summary.

Event Timeline

Kizule created this task.Jun 28 2019, 11:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2019, 11:32 AM

Actual Results:
It will open Special:Delete page in new tab and will show content was: (something)
Expected Results:
It should show summary Broken redirect or something simular.

Why do you expect the "Delete" button to NOT open Special:Delete page anymore? This makes no sense to me...

Aklapper renamed this task from [FEAT] Add custom summary for deleting broken redirects from Special:BrokenRedirects instead of default by MediaWiki to Add custom summary for deleting broken redirects from Special:BrokenRedirects instead of default by MediaWiki.Jun 28 2019, 12:21 PM

In T226824#5292089, @Aklapper wrote:

Actual Results:
It will open Special:Delete page in new tab and will show content was: (something)
Expected Results:
It should show summary Broken redirect or something simular.

Why do you expect the "Delete" button to NOT open Special:Delete page anymore? This makes no sense to me...

No, you misunderstand me. It should open Special:Delete page and in summary put Broken redirect no content was: (content)

@Zoranzoki21: Then "It will open Special:Delete page" should also be under "Expected Results" or moved to "Steps to Reproduce" as a "End up on the Special:Delete page" item? :)
I admit I don't understand yet what is asked for in this task, sorry... :-/

Kizule updated the task description. (Show Details)Jun 29 2019, 3:02 PM

A prefilled reason can be specified using &wpReason=foo at the end of the link to delete the redirect.

Currently, the delete link is coded in SpecialBrokenRedirects::formatResult:

SpecialBrokenRedirects::formatResult

if ( $permissionManager->userHasRight( $this->getUser(), 'delete' ) ) {
	$links[] = $linkRenderer->makeKnownLink(
		$fromObj,
		$this->msg( 'brokenredirects-delete' )->text(),
		[],
		[ 'action' => 'delete' ]
	);
}

to implement the requested feature, a new interface message, brokenredirects-delete-reason can be added and, if the message exists, it will be prefilled as the default message

Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 10 2019, 5:42 AM

Change 542312 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add default deletion reason for deleting broken redirects.

https://gerrit.wikimedia.org/r/542312

gerritbot added a project: Patch-For-Review.Oct 11 2019, 5:04 AM

Change 542313 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[translatewiki@master] Don't translate brokenredirects-delete-reason.

https://gerrit.wikimedia.org/r/542313

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Oct 11 2019, 5:11 AM

Tgr mentioned this in T239012: Remove autogeneration of Deletion summary..Nov 24 2019, 8:05 PM

1997kB moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Dec 24 2019, 2:02 PM

1997kB moved this task from Special:Contributions / Special:DeletedContributions to To triage on the MediaWiki-Special-pages board.Dec 24 2019, 2:31 PM

matej_suchanek moved this task from To triage to Maintenance reports on the MediaWiki-Special-pages board.Feb 26 2020, 10:19 AM

+CPT. Could you please take a look at the patch? Thanks!

CCicalese_WMF edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.May 19 2020, 1:06 PM

Change 542312 merged by jenkins-bot:
[mediawiki/core@master] Add default deletion reason for deleting broken redirects.

https://gerrit.wikimedia.org/r/542312

DannyS712 closed this task as Resolved.Jul 8 2020, 11:41 AM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 8 2020, 12:00 PM

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Jul 9 2020, 11:17 PM

Change 542313 abandoned by Raimond Spekking:
[translatewiki@master] Don't translate brokenredirects-delete-reason.

Reason:
I am really sorry but I have forgotten this ~ 9 months old patch and submitted a new one: https://gerrit.wikimedia.org/r/c/translatewiki/ /610277