Page MenuHomePhabricator
Create Task
Maniphest T216839

Deduplicate I18N messages between Wikibase and WikibaseCirrusSearch
Closed, ResolvedPublic
Actions

Description

This is apparently causing some logspam.
We should rename i18n entries in WikibaseCirrusSearch so that they no longer conflict with Wikibase.
This was reported on IRC:

16:38 <Nikerabbit> Key 8:wikibase-haswbstatement-feature-no-valid-statements already belongs to ext-wikibase-repo-interface, conflict with ext-wikibasecirrussearch
16:38 <Nikerabbit> anyone know that code?
16:56 <Nikerabbit> not urgent, just a little bit of logspam
17:02 <+dcausse> Nikerabbit: yes an extension is being moved out of wikibase, the solution is to rename the message key?
17:24 <Nikerabbit> dcausse: original key should be removed from wikibase if unused there, otherwise rename

Details

SubjectRepoBranchLines +/-
Rename i18n strings for the extensionmediawiki/extensions/WikibaseCirrusSearchmaster+200 -200
Customize query in gerrit

Related Objects

Event Timeline

dcausse created this task.Feb 22 2019, 5:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2019, 5:12 PM
dcausse renamed this task from Deduplicate I18N messages between Wikbase and WikibaseCirrusSearch to Deduplicate I18N messages between Wikibase and WikibaseCirrusSearch.Feb 22 2019, 5:13 PM
dcausse triaged this task as Medium priority.
dcausse moved this task from needs triage to Wikibase Search on the Discovery-Search board.
Smalyshev added a subscriber: Nikerabbit.Feb 22 2019, 7:17 PM

This is a bit tricky, since we have transition period. I could change the names, but then any edits to the old ones done while in transition (and this could be weeks) will be lost. We could remove the Wikibase part but I am not sure it's safe to do now that the extension is not enabled yet on all wikis.

Smalyshev added a project: MediaWiki-Internationalization.Feb 22 2019, 7:30 PM
gerritbot subscribed.Feb 22 2019, 8:26 PM

Change 492382 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseCirrusSearch@master] Rename i18n strings for the extension

https://gerrit.wikimedia.org/r/492382

gerritbot added a project: Patch-For-Review.Feb 22 2019, 8:26 PM
Diffusion mentioned this in rEWCSfcb488638388: Rename i18n strings for the extension.Feb 22 2019, 8:27 PM
Nikerabbit added a comment.Feb 24 2019, 5:14 PM

How about putting the duplicated messages in WikibaseCirrusSearch to another i18n file that is not registered in translatewiki.net?

Diffusion mentioned this in rEWCSd12ecdc33a25: Rename i18n strings for the extension.Feb 25 2019, 7:50 AM
Diffusion mentioned this in rEWCS0caa3c1637d5: Rename i18n strings for the extension.Feb 25 2019, 10:04 PM
gerritbot added a comment.Feb 26 2019, 6:58 PM

Change 492382 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Rename i18n strings for the extension

https://gerrit.wikimedia.org/r/492382

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 11:02 AM
Smalyshev edited projects, added Discovery-Search (Current work); removed Discovery-Search.Mar 5 2019, 6:53 PM
Smalyshev moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
debt closed this task as Resolved.Mar 8 2019, 5:53 PM
debt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits