Page MenuHomePhabricator
Create Task
Maniphest T207719

The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled
Closed, ResolvedPublic
Actions

Description

In the VisualEditor, click the ≡ icon and click "Options" to get to the meta / "Page options" dialog.
Here, the "Apply changes" button is always enabled. It should only be enabled if the user has made any changes in the dialog.

Details

SubjectRepoBranchLines +/-
ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')mediawiki/extensions/VisualEditormaster+18 -5
ve.ui.MWMetaDialog: Consider category sortkeys when checking for changesmediawiki/extensions/VisualEditormaster+1 -1
ve.ui.MWMetaDialog: "Apply changes" is now only enabled after making changesmediawiki/extensions/VisualEditormaster+145 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Oct 23 2018, 4:44 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 23 2018, 4:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a parent task: T206000: Apply changes action is enabled on several dialogs before any changes are made.Oct 23 2018, 4:44 AM
matmarex added a parent task: T74971: If the input for the redirect in the meta dialog is invalid, as well as show a red outline, block the user from closing the dialog with a prompt to fix it.
matmarex added a project: Google-Code-in-2018.Oct 23 2018, 5:11 AM

I would like to mentor this task in Google-Code-in-2018.

Aklapper updated the task description. (Show Details)Oct 23 2018, 1:37 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/4573690701283328/

gerritbot subscribed.Oct 28 2018, 8:33 PM

Change 470254 had a related patch set uploaded (by Flutterish; owner: Flutterish):
[mediawiki/extensions/VisualEditor@master] "Apply changes" is now only enabled after making changes

https://gerrit.wikimedia.org/r/470254

gerritbot added a project: Patch-For-Review.Oct 28 2018, 8:33 PM
gerritbot added a comment.Oct 30 2018, 7:10 PM

Change 470661 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')

https://gerrit.wikimedia.org/r/470661

gerritbot added a comment.Oct 30 2018, 7:29 PM

Change 470254 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: "Apply changes" is now only enabled after making changes

https://gerrit.wikimedia.org/r/470254

gerritbot added a comment.Oct 30 2018, 7:58 PM

Change 470671 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Consider category sortkeys when checking for changes

https://gerrit.wikimedia.org/r/470671

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Oct 30 2018, 8:00 PM
matmarex added a comment.Oct 30 2018, 8:19 PM

https://gerrit.wikimedia.org/r/470661 fixes a pre-existing issue in the "Categories" page of the dialog that interferes with this new feature.

https://gerrit.wikimedia.org/r/470671 makes this work when updating category sortkeys (I forgot about them when reviewing the original patch, sorry).

gerritbot added a comment.Oct 30 2018, 9:01 PM

Change 470671 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Consider category sortkeys when checking for changes

https://gerrit.wikimedia.org/r/470671

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.Oct 30 2018, 9:36 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
matmarex moved this task from QA to Code review on the VisualEditor (Current work) board.Oct 31 2018, 6:56 PM
gerritbot added a comment.Nov 1 2018, 11:03 PM

Change 470661 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMetaDialog: Wait for each page to set up (especially 'category')

https://gerrit.wikimedia.org/r/470661

Jdforrester-WMF assigned this task to Flutterish.Nov 1 2018, 11:04 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
Jdforrester-WMF subscribed.

Joint with @matmarex for the extra fixes. :-)

matmarex closed this task as Resolved.Nov 2 2018, 12:03 AM
matmarex mentioned this in T206000: Apply changes action is enabled on several dialogs before any changes are made.Nov 15 2018, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits