Maniphest T192425

ApiBaseTest::testGetParameterFromSettings fails to assert 1000 is identical to 1 (PHP 7.1+)
Closed, ResolvedPublic
Actions

Description

Current master seems to fail PHP 7.1 on Travis at https://travis-ci.org/wikimedia/mediawiki/jobs/367942995

1) ApiBaseTest::testGetParameterFromSettings with data set ""1e3" as integer" ('1e3', array('integer'), 1, array())
Failed asserting that 1000 is identical to 1.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/api/ApiBaseTest.php:280
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:421
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94

Also with PHP 7.2 at https://travis-ci.org/wikimedia/mediawiki/jobs/367942994

--
There were 7 failures:
1) ApiBaseTest::testGetParameterFromSettings with data set ""1e3" as integer" ('1e3', array('integer'), 1, array())
Failed asserting that 1000 is identical to 1.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/api/ApiBaseTest.php:280
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:421
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94

This is a regression since last week. Git log identifies d3da5e08d35f67 as a probable cause.

Details

	Subject	Repo	Branch	Lines +/-
	API: Remove 1e3>1 test case from ApiBaseTest	mediawiki/core	master	+0 -1
	API: Remove 1e3>1 test case from ApiBaseTest	mediawiki/core	REL1_31	+0 -1

Customize query in gerrit

Related Objects

Mentioned Here: T182366: UploadBaseTest::testCheckXMLEncodingMissmatch failing on PHP 7.1
rMWd3da5e08d35f: Improve test coverage for ApiBase.php

Event Timeline

Krinkle created this task.Apr 18 2018, 2:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2018, 2:21 AM

Krinkle renamed this task from ApiBaseTest::testGetParameterFromSettings fails to assert 1000 is identical to 1 (PHP 7.1) to ApiBaseTest::testGetParameterFromSettings fails to assert 1000 is identical to 1 (PHP 7.1+).Apr 18 2018, 2:22 AM

Krinkle added a project: PHP 7.2 support.

Krinkle updated the task description. (Show Details)

Sigh, PHP inconsistencies: https://3v4l.org/fCMP8

Probably the easiest fix is to just remove the test. Or we could make the validation more strict by rejecting values that don't match /^[+-]?\d+$/ or the like, and adjusting the test to match.

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Apr 18 2018, 1:36 PM

Krinkle added a project: MW-1.31-release.Apr 18 2018, 5:22 PM

Krinkle moved this task from Backlog to Core on the MW-1.31-release board.Apr 18 2018, 6:08 PM

Krinkle triaged this task as High priority.Apr 18 2018, 7:32 PM

Krinkle moved this task from Backlog to MediaWiki core on the PHP 7.1 support board.

Krinkle moved this task from Untriaged to MediaWiki core on the PHP 7.2 support board.

Change 427562 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] API: Remove 1e3>1 test case from ApiBaseTest

https://gerrit.wikimedia.org/r/427562

gerritbot added a project: Patch-For-Review.Apr 18 2018, 11:11 PM

Jdforrester-WMF subscribed.Apr 19 2018, 12:27 AM

Change 427562 merged by jenkins-bot:
[mediawiki/core@master] API: Remove 1e3>1 test case from ApiBaseTest

https://gerrit.wikimedia.org/r/427562

Change 427577 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_31] API: Remove 1e3>1 test case from ApiBaseTest

https://gerrit.wikimedia.org/r/427577

The latest PHP 7.1 build at Travis no longer shows this error. Only remaining failure on PHP 7.1 is T182366.

Change 427577 merged by jenkins-bot:
[mediawiki/core@REL1_31] API: Remove 1e3>1 test case from ApiBaseTest

https://gerrit.wikimedia.org/r/427577

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 19 2018, 2:00 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:35 PM

ApiBaseTest::testGetParameterFromSettings fails to assert 1000 is identical to 1 (PHP 7.1+)Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ApiBaseTest::testGetParameterFromSettings fails to assert 1000 is identical to 1 (PHP 7.1+)
Closed, ResolvedPublic
Actions