Page MenuHomePhabricator

Advanced search & MinervaNeue: Help popup styling is broken in several ways
Closed, ResolvedPublic

Description

As of 2018:

minervaNeu2.png (327×351 px, 26 KB)

As of 2022:

Screenshot from 2022-05-18 10-18-25.png (347×372 px, 43 KB)

Issues:

  • It appears like the <code> tags are not styled any more. The reason seems to be that MinervaNeue now uses a top-level CSS class .content. Adding this to the body container of our popups is an option.
  • It looks like we need to fix the (missing) top and bottom padding of the popups as well.
  • There are many ways to fix the overlapping <code> rectangles: add a background-color: #fff, decrease or remove some of the padding, increase the line-height.
  • The scrollbar is because of some dl dd { overflow: auto; } in the MinervaNeue CSS. As of 2022 this might not be a problem any more. If it is, we should reset it to overflow: visible in our popups.
  • After fixing the obvious errors we might need to turn this into a WMDE-Design task for the final touches.

Browser: Chromium

Demo of the result:
https://en.wikipedia.beta.wmflabs.org/w/index.php?search=&title=Special%3ASearch&useskin=minerva

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde renamed this task from Advanced search & MinervaNeu: Overlaing boxes around keywords to Advanced search & MinervaNeue: Help popup styling is broken in several ways.May 18 2022, 8:45 AM
thiemowmde added a project: patch-welcome.
thiemowmde updated the task description. (Show Details)
thiemowmde subscribed.

Change 973294 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/AdvancedSearch@master] Fix popup styling in Minerva Neue skin

https://gerrit.wikimedia.org/r/973294

Change 973294 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Fix popup styling in Minerva Neue skin

https://gerrit.wikimedia.org/r/973294