Page MenuHomePhabricator
Create Task
Maniphest T188920

Test search and category search
Closed, ResolvedPublic
Actions

Description

We recently fixed a couple untracked bugs in search and category search. This task encompasses the work to do some light testing on adding and removing categories from a wiki page and searching the wiki for a page.

  1. Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page
  2. Tap the search box
  3. Perform a few searches as a user would
  4. Change the search result watchlist state and make sure it persists after a refresh
  1. Visit https://en.m.wikipedia.beta.wmflabs.org
  2. Go to an article
  3. Add a few categories

Details

SubjectRepoBranchLines +/-
Fix: watchstar event emitter contextmediawiki/extensions/MobileFrontendmaster+4 -4
Fix: request abortion and response check for searchmediawiki/extensions/MobileFrontendmaster+12 -9
Customize query in gerrit

Event Timeline

• Niedzielski created this task.Mar 5 2018, 4:39 PM
Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptMar 5 2018, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Mar 5 2018, 4:42 PM

Change 416464 had a related patch set uploaded (by Jhernandez; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: request abortion and response check for search

https://gerrit.wikimedia.org/r/416464

gerritbot added a project: Patch-For-Review.Mar 5 2018, 4:42 PM
gerritbot added a comment.Mar 5 2018, 5:00 PM

Change 416464 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: request abortion and response check for search

https://gerrit.wikimedia.org/r/416464

ovasileva triaged this task as High priority.Mar 5 2018, 5:03 PM
ovasileva moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.Mar 5 2018, 5:12 PM
• Niedzielski updated the task description. (Show Details)Mar 5 2018, 5:34 PM
gerritbot added a comment.Mar 5 2018, 5:35 PM

Change 416477 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: watchstar event emitter context

https://gerrit.wikimedia.org/r/416477

gerritbot added a comment.Mar 5 2018, 7:03 PM

Change 416477 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: watchstar event emitter context

https://gerrit.wikimedia.org/r/416477

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Mar 6 2018, 12:24 AM

Seems to be working for me. Tried a variety of browsers and devices.

• Niedzielski added a comment.Mar 6 2018, 2:14 AM

Thanks @ABorbaWMF!!!

ovasileva closed this task as Resolved.Mar 6 2018, 12:05 PM
ovasileva subscribed.

all done!

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits