Page MenuHomePhabricator

Upgrade to squizlabs/php_codesniffer 3.2.1
Closed, ResolvedPublic

Description

Event Timeline

Change 398050 had a related patch set uploaded (by Legoktm; owner: Ricordisamoa):
[mediawiki/tools/codesniffer@master] Update PHP_CodeSniffer to 3.2.0

https://gerrit.wikimedia.org/r/398050

It should be noted that the old-style @codingStandards comments, although deprecated, will continue to work until PHP_CodeSniffer 4.
Are you aware of any critical breaking changes between 3.1.1 and 3.2.0?

I was concerned with the fix for IDE plugins, but he just released 3.2.1 (https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.2.1) so that looks good to go from my point of view.

Legoktm renamed this task from Upgrade to squizlabs/php_codesniffer 3.2.0 to Upgrade to squizlabs/php_codesniffer 3.2.1.Dec 18 2017, 8:09 AM
Legoktm updated the task description. (Show Details)

Change 398050 had a related patch set uploaded (by Ricordisamoa; owner: Ricordisamoa):
[mediawiki/tools/codesniffer@master] Update PHP_CodeSniffer to 3.2.1

https://gerrit.wikimedia.org/r/398050

Change 398050 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Update PHP_CodeSniffer to 3.2.1

https://gerrit.wikimedia.org/r/398050