Page MenuHomePhabricator
Create Task
Maniphest T182377

Parameter must be an array or an object that implements Countable
Closed, ResolvedPublic
Actions

Description

Seen on travis on PHP 7.2 https://travis-ci.org/wikimedia/mediawiki/jobs/368430010

  • 30 December 2017: 8x errors for "Parameter must be an array or an object that implements Countable"
  • 18 April 2018: 11x errors for "Parameter must be an array or an object that implements Countable"
  • 9 June 2018: 3x errors for "Parameter must be an array or an object that implements Countable"
1) BitmapMetadataHandlerTest::testMultilingualCascade
count(): Parameter must be an array or an object that implements Countable
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:745
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:336
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:308
/home/travis/build/wikimedia/mediawiki/includes/media/BitmapMetadataHandler.php:92
/home/travis/build/wikimedia/mediawiki/includes/media/BitmapMetadataHandler.php:188
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php:32
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:420
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
2) ExifTest::testGPSExtraction
count(): Parameter must be an array or an object that implements Countable
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:745
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:336
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:308
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/media/ExifTest.php:24
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:420
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94
3) ExifTest::testUnicodeUserComment
count(): Parameter must be an array or an object that implements Countable
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:745
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:336
/home/travis/build/wikimedia/mediawiki/includes/media/Exif.php:308
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/media/ExifTest.php:39
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:420
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94

Details

SubjectRepoBranchLines +/-
Guard against uncountable tag valuesmediawiki/coreREL1_31+9 -4
media: Only run count() on array() in Exif classmediawiki/coremaster+14 -11
Guard against uncountable tag valuesmediawiki/coremaster+8 -4
userrights: Add array typehints to SpecialUserrights methodsmediawiki/coreREL1_31+5 -5
userrights: Add array typehints to SpecialUserrights methodsmediawiki/coremaster+5 -5
API: Fix PHP Warning for "count(): Parameter must be an array"mediawiki/coreREL1_31+3 -2
API: Fix PHP Warning for "count(): Parameter must be an array"mediawiki/coremaster+3 -2
ApiQueryBase: Fix addWhereFld for PHP 7.2mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 8 2017, 2:50 AM
Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptDec 8 2017, 2:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy moved this task from Unsorted to PHP 7.2 on the [DO NOT USE] NewPHP board.Dec 8 2017, 2:56 AM
gerritbot subscribed.Dec 8 2017, 4:48 PM

Change 396426 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiQueryBase: Fix addWhereFld for PHP 7.2

https://gerrit.wikimedia.org/r/396426

gerritbot added a project: Patch-For-Review.Dec 8 2017, 4:48 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Dec 8 2017, 4:52 PM
Anomie moved this task from Needs Review to Done on the MediaWiki-Action-API board.Dec 8 2017, 5:48 PM
gerritbot added a comment.Dec 8 2017, 5:52 PM

Change 396426 merged by jenkins-bot:
[mediawiki/core@master] ApiQueryBase: Fix addWhereFld for PHP 7.2

https://gerrit.wikimedia.org/r/396426

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 8 2017, 6:00 PM
Reedy removed a project: Patch-For-Review.Dec 30 2017, 2:04 AM
Reedy updated the task description. (Show Details)Dec 30 2017, 2:08 AM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)
gerritbot added a comment.Dec 30 2017, 2:34 AM

Change 400916 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Only run count() on array()

https://gerrit.wikimedia.org/r/400916

gerritbot added a project: Patch-For-Review.Dec 30 2017, 2:34 AM
• Ramsey-WMF removed a project: Multimedia.Jan 5 2018, 5:56 PM
RazeSoldier closed subtask T184934: SearchEngine.php uses count() on non-countable SearchSuggestionSet, producing warning in PHP 7.2 as Resolved.Jan 30 2018, 5:17 AM
Jdforrester-WMF edited projects, added PHP 7.2 support; removed [DO NOT USE] NewPHP.Feb 27 2018, 10:50 PM
Jdforrester-WMF moved this task from Untriaged to MediaWiki core on the PHP 7.2 support board.Feb 27 2018, 11:00 PM
Krinkle updated the task description. (Show Details)Apr 19 2018, 1:36 AM
gerritbot added a comment.Apr 19 2018, 1:43 AM

Change 427580 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] API: Fix PHP Warning for "count(): Parameter must be an array"

https://gerrit.wikimedia.org/r/427580

gerritbot added a comment.Apr 19 2018, 5:59 PM

Change 427728 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] userrights: Add array typehints to SpecialUserrights methods

https://gerrit.wikimedia.org/r/427728

gerritbot added a comment.Apr 19 2018, 5:59 PM

Change 427729 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_31] API: Fix PHP Warning for "count(): Parameter must be an array"

https://gerrit.wikimedia.org/r/427729

gerritbot added a comment.Apr 19 2018, 6:13 PM

Change 427580 merged by jenkins-bot:
[mediawiki/core@master] API: Fix PHP Warning for "count(): Parameter must be an array"

https://gerrit.wikimedia.org/r/427580

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 19 2018, 7:00 PM
gerritbot added a comment.Apr 19 2018, 10:10 PM

Change 427729 merged by jenkins-bot:
[mediawiki/core@REL1_31] API: Fix PHP Warning for "count(): Parameter must be an array"

https://gerrit.wikimedia.org/r/427729

ReleaseTaggerBot edited projects, added MW-1.31-release-notes; removed MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Apr 19 2018, 11:00 PM
gerritbot added a comment.Apr 23 2018, 4:18 PM

Change 427728 merged by jenkins-bot:
[mediawiki/core@master] userrights: Add array typehints to SpecialUserrights methods

https://gerrit.wikimedia.org/r/427728

Reedy updated the task description. (Show Details)Jun 9 2018, 2:30 AM
Reedy updated the task description. (Show Details)Jun 9 2018, 2:37 AM
Reedy removed projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-Action-API, Commons.
Reedy removed a project: Patch-For-Review.
Reedy merged a task: T197893: PHP Warning: count(): Parameter must be an array or an object that implements Countable in /srv/mediawiki/w/includes/media/Exif.php on line 745.Jun 21 2018, 7:21 PM
Reedy added subscribers: Paladox, Anomie, Legoktm.
gerritbot added a comment.Jun 21 2018, 7:24 PM

Change 441428 had a related patch set uploaded (by Paladox; owner: Krinkle):
[mediawiki/core@REL1_31] userrights: Add array typehints to SpecialUserrights methods

https://gerrit.wikimedia.org/r/441428

gerritbot added a project: Patch-For-Review.Jun 21 2018, 7:24 PM
gerritbot added a comment.Jun 21 2018, 7:28 PM

Change 441428 abandoned by Paladox:
userrights: Add array typehints to SpecialUserrights methods

Reason:
Hmm i can abandon then and sorry. Also i was backporting this as it may not fix a issue i have seen but seemed to fix other count issues?

https://gerrit.wikimedia.org/r/441428

Johnywhy subscribed.Jun 25 2018, 7:33 AM

related?
https://phabricator.wikimedia.org/T197893#4310406

Aklapper added a comment.Jun 25 2018, 9:00 AM

@Johnywhy: https://phabricator.wikimedia.org/T197893 only lists files in the FlaggedRevs codebase. This task is about code in MediaWiki core. Why should it be related?

Samwilson subscribed.Jun 26 2018, 10:10 AM
gerritbot added a comment.Jun 30 2018, 7:58 AM

Change 443206 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/443206

RazeSoldier merged a task: T200179: Parameter must be an array or an object that implements Countable in Media test.Jul 23 2018, 9:06 AM
RazeSoldier subscribed.
gerritbot added a comment.Jul 28 2018, 9:43 PM

Change 443206 merged by jenkins-bot:
[mediawiki/core@master] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/443206

gerritbot added a comment.Jul 28 2018, 9:45 PM

Change 448976 had a related patch set uploaded (by Paladox; owner: Samwilson):
[mediawiki/core@REL1_31] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/448976

MaxSem closed this task as Resolved.Jul 28 2018, 9:45 PM
MaxSem assigned this task to Samwilson.
gerritbot added a comment.Aug 1 2018, 5:52 PM

Change 400916 abandoned by Krinkle:
media: Only run count() on array() in Exif class

Reason:
Superseded by I7ca38bc55ae04f

https://gerrit.wikimedia.org/r/400916

gerritbot added a comment.Aug 2 2018, 11:07 PM

Change 448976 merged by jenkins-bot:
[mediawiki/core@REL1_31] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/448976

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits