Page MenuHomePhabricator
Create Task
Maniphest T164724

Diff on medium sized table takes a very long time then shows no diff
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Edit a few cells in a ~200 cells table. The visual diff takes a few seconds to load and shows no changes.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (347765f82)mediawiki/extensions/VisualEditormaster+1 -1
Upgrade tree differ to support timeouts, and handle themVisualEditor/VisualEditormaster+16 -1
Generate visual diff only after switching to visual diff tabmediawiki/extensions/VisualEditormaster+16 -12
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 8 2017, 10:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2017, 10:08 AM
Esanders added a comment.May 8 2017, 10:13 AM

The lack of diff is cause by the timeout code - although it should result in the entire table being replaced. Also the timeout happens too high up to catch the slow tree diff.

Esanders merged a task: T164763: Visual diff on a specific page on Officewiki hangs forever.May 8 2017, 4:47 PM
Esanders added a subscriber: matmarex.
gerritbot subscribed.May 8 2017, 7:09 PM

Change 352642 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Generate visual diff only after switching to visual diff tab

https://gerrit.wikimedia.org/r/352642

gerritbot added a project: Patch-For-Review.May 8 2017, 7:09 PM
gerritbot added a comment.May 8 2017, 8:36 PM

Change 352669 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Upgrade tree differ to support timeouts, and handle them

https://gerrit.wikimedia.org/r/352669

• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.May 9 2017, 10:07 AM
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
Aklapper reopened this task as Open.May 9 2017, 10:19 AM
gerritbot added a comment.May 9 2017, 1:31 PM

Change 352642 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Generate visual diff only after switching to visual diff tab

https://gerrit.wikimedia.org/r/352642

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 9 2017, 2:00 PM
gerritbot added a comment.May 10 2017, 2:38 PM

Change 352669 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Upgrade tree differ to support timeouts, and handle them

https://gerrit.wikimedia.org/r/352669

Jdforrester-WMF closed this task as Resolved.May 10 2017, 5:47 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-VisualDiffs; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 10 2017, 5:47 PM
gerritbot added a comment.May 11 2017, 7:44 PM

Change 353367 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (347765f82)

https://gerrit.wikimedia.org/r/353367

gerritbot added a project: Patch-For-Review.May 11 2017, 7:44 PM
gerritbot added a comment.May 12 2017, 6:42 PM

Change 353367 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (347765f82)

https://gerrit.wikimedia.org/r/353367

Jdforrester-WMF removed a project: Patch-For-Review.May 12 2017, 6:59 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)); removed MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 12 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits