Restoration of deleted items broken on Wikidata
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jasper
	Apr 17 2017, 8:05 PM

Description

It has been found that administrators can't restore deleted items - they can only view previously deleted revisions. A likely unintended side-effect of T108138.

Details

Subject	Repo	Branch	Lines +/-
Fix undeleting Entities permission errors.	mediawiki/extensions/Wikibase	master	+77 -0
Add the "UndeletePermissionErrors" hook	mediawiki/core	master	+8 -0
Rely on ContentHandler::supportsDirectEditing being false	mediawiki/extensions/Wikibase	master	+2 -38

Customize query in gerrit

Revisions and Commits

rEWBA extension-Wikibase
	rEWBA3ac3e853a9dc Rely on ContentHandler::supportsDirectEditing being false

Related Objects

Mentioned In: T108138: Sysops can undelete pages, although the page is protected against it
Mentioned Here: T108138: Sysops can undelete pages, although the page is protected against it

Event Timeline

Jasper created this task.Apr 17 2017, 8:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2017, 8:05 PM

'create' on Wikidata in the main namespace is blocked by the 'wikibase-no-direct-editing' error. Therefore 'undelete' now fails with 'undelete-cantcreate' which was added in T108138: Sysops can undelete pages, although the page is protected against it.

Legoktm mentioned this in T108138: Sysops can undelete pages, although the page is protected against it.Apr 17 2017, 8:07 PM

Sjoerddebruin subscribed.Apr 17 2017, 8:07 PM

Stryn subscribed.Apr 17 2017, 8:07 PM

Addshore triaged this task as High priority.Apr 17 2017, 8:07 PM

Addshore added a project: Regression.

Addshore added a subscriber: Lydia_Pintscher.

Jdforrester-WMF subscribed.Apr 17 2017, 8:08 PM

HakanIST subscribed.Apr 17 2017, 8:09 PM

Ymblanter subscribed.Apr 17 2017, 8:36 PM

• MZMcBride subscribed.Apr 17 2017, 10:41 PM

Change 348692 had a related patch set uploaded (by Hoo man):
[mediawiki/core@master] Add the "UndeletePermissionErrors" hook

https://gerrit.wikimedia.org/r/348692

gerritbot added a project: Patch-For-Review.Apr 18 2017, 9:04 AM

thiemowmde assigned this task to hoo.Apr 18 2017, 9:26 AM

thiemowmde moved this task from incoming to in progress on the Wikidata board.

thiemowmde added a project: Wikidata-Former-Sprint-Board.

thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

thiemowmde added subscribers: thiemowmde, aude, Addshore.

Change 348695 had a related patch set uploaded (by Hoo man):
[mediawiki/extensions/Wikibase@master] Fix undeleting Entities permission errors.

https://gerrit.wikimedia.org/r/348695

WMDE-leszek subscribed.Apr 18 2017, 5:55 PM

Change 348905 had a related patch set uploaded (by Hoo man):
[mediawiki/extensions/Wikibase@master] Rely on ContentHandler::supportsDirectEditing being false

https://gerrit.wikimedia.org/r/348905

Change 348905 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rely on ContentHandler::supportsDirectEditing being false

https://gerrit.wikimedia.org/r/348905

hoo closed this task as Resolved by committing rEWBA3ac3e853a9dc: Rely on ContentHandler::supportsDirectEditing being false.Apr 23 2017, 3:27 PM

hoo added a commit: rEWBA3ac3e853a9dc: Rely on ContentHandler::supportsDirectEditing being false.

I still can not restore [[:d:Q3856077]]

It likely has not been deployed yet. Thanks for checking.
@hoo when will it be deployed?

Lea_Lacroix_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Apr 24 2017, 9:57 AM