Page MenuHomePhabricator
Create Task
Maniphest T151536

Remove mixups of OATH and OAUTH
Closed, ResolvedPublic
Actions

Description

I notice several usages of OAuth in the extensions which likely are intended to refer to OATH

  • message key: oathauth-failedtovalidateoauth
    • I also notice a few other keys in the i18n with this pattern, but I can't find where they are used...
    • oathauth-failedtoenableoauth, oathauth-failedtovalidateoauth, oathauth-failedtodisableoauth, oathauth-failedtoenableoauth, oathauth-failedtovalidateoauth, oathauth-failedtodisableoauth
  • memckey for used tokens in OATHAuthKey.php
  • throttle limiter uses oauthauth-throttled instead of oathauth-throttled in special/SpecialOATHDisable.php
  • Some more in message keys that i haven't fully figured out...

Details

SubjectRepoBranchLines +/-
OathAuth: rename failedtovalidateoauthmediawiki/extensions/OATHAuthmaster+4 -4
More unused oathauth message keysmediawiki/extensions/OATHAuthmaster+0 -34
typo in comment: OAuth -> Oathmediawiki/extensions/OATHAuthmaster+1 -1
OAuth -> OATH for used tokens memcachemediawiki/extensions/OATHAuthmaster+1 -1
Disable page was using the OAuth throttler instead of OATHmediawiki/extensions/OATHAuthmaster+1 -1
Customize query in gerrit

Event Timeline

TheDJ created this task.Nov 24 2016, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2016, 9:59 AM
gerritbot subscribed.Nov 24 2016, 10:01 AM

Change 323379 had a related patch set uploaded (by TheDJ):
typo in comment: OAuth -> Oath

https://gerrit.wikimedia.org/r/323379

gerritbot added a project: Patch-For-Review.Nov 24 2016, 10:01 AM
gerritbot added a comment.Nov 24 2016, 10:07 AM

Change 323381 had a related patch set uploaded (by TheDJ):
OAuth -> OATH for used tokens memcache

https://gerrit.wikimedia.org/r/323381

TheDJ updated the task description. (Show Details)Nov 24 2016, 10:12 AM
gerritbot added a comment.Nov 24 2016, 10:17 AM

Change 323380 had a related patch set uploaded (by TheDJ):
Disable page was using the OAuth throttler instead of OATH

https://gerrit.wikimedia.org/r/323380

gerritbot added a comment.Nov 26 2016, 9:14 PM

Change 323380 merged by jenkins-bot:
Disable page was using the OAuth throttler instead of OATH

https://gerrit.wikimedia.org/r/323380

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 2:01 AM
gerritbot added a comment.Dec 4 2016, 1:22 PM

Change 323381 merged by jenkins-bot:
OAuth -> OATH for used tokens memcache

https://gerrit.wikimedia.org/r/323381

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 4 2016, 2:00 PM
TheDJ updated the task description. (Show Details)Dec 5 2016, 9:21 AM
gerritbot added a comment.Dec 9 2016, 1:43 AM

Change 323379 merged by jenkins-bot:
typo in comment: OAuth -> Oath

https://gerrit.wikimedia.org/r/323379

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 9 2016, 2:00 AM
gerritbot added a comment.Apr 21 2017, 7:01 PM

Change 349516 had a related patch set uploaded (by TheDJ):
[mediawiki/extensions/OATHAuth@master] More unused oathauth message keys

https://gerrit.wikimedia.org/r/349516

gerritbot removed projects: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Apr 21 2017, 7:01 PM

Change 349517 had a related patch set uploaded (by TheDJ):
[mediawiki/extensions/OATHAuth@master] OathAuth: rename failedtovalidateoauth

https://gerrit.wikimedia.org/r/349517

TheDJ claimed this task.Apr 21 2017, 7:03 PM
TheDJ triaged this task as Lowest priority.

There should now be patches for all of these remaining message key issues

TheDJ moved this task from Backlog to In Progress on the MediaWiki-extensions-OATHAuth board.Apr 21 2017, 7:04 PM
gerritbot added a comment.Apr 26 2017, 5:19 PM

Change 349516 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] More unused oathauth message keys

https://gerrit.wikimedia.org/r/349516

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 26 2017, 6:00 PM
gerritbot added a comment.May 10 2017, 3:18 PM

Change 349517 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] OathAuth: rename failedtovalidateoauth

https://gerrit.wikimedia.org/r/349517

TheDJ closed this task as Resolved.May 10 2017, 3:23 PM
TheDJ removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)); removed MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 10 2017, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits