Page MenuHomePhabricator
Create Task
Maniphest T148565

video.js mode scrub bar displays backwards in RTL languages
Closed, ResolvedPublic
Actions

Description

In video.js mode, the scrub bar on video/audio player displays backwards, counting playtime from the right instead of from the left.

(Media controls should look the same in RTL as they do in LTR, which is to say "forward" is to the right. See T44471 for past problems with MwEmbedPlayer.)

This is probably an upstream video.js issue. seems to be a CSSJanus issue; upstream CSS works in isolation.

Screen Shot 2016-10-18 at 11.03.51 AM.png (1×2 px, 1 MB)

Details

SubjectRepoBranchLines +/-
Fix videojs mode control bar in RTLmediawiki/extensions/TimedMediaHandlermaster+1 -0
Add 'noflip' option on RL modules to disable CSSJanusmediawiki/coremaster+13 -1
Customize query in gerrit

Related Objects

Event Timeline

• brooke created this task.Oct 18 2016, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 6:15 PM
• brooke added a comment.Oct 18 2016, 6:32 PM

Isolated test case looks ok... I think it's CSSJanus running over the video-js.css file. Is there a way we can force "@noflip" on an entire file?

• brooke removed a project: Upstream.Oct 18 2016, 6:50 PM
• brooke updated the task description. (Show Details)
TheDJ moved this task from Backlog to Video.js on the Kaltura player board.Oct 18 2016, 6:52 PM
• brooke mentioned this in T148572: Add 'noflip' option to ResourceLoader modules to disable CSSJanus flipping globally for the module.Oct 18 2016, 7:02 PM
gerritbot subscribed.Oct 18 2016, 7:07 PM

Change 316611 had a related patch set uploaded (by Brion VIBBER):
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

gerritbot added a project: Patch-For-Review.Oct 18 2016, 7:07 PM
gerritbot added a comment.Oct 18 2016, 7:10 PM

Change 316612 had a related patch set uploaded (by Brion VIBBER):
Fix videojs mode control bar in RTL

https://gerrit.wikimedia.org/r/316612

Paladox subscribed.Oct 18 2016, 11:34 PM
gerritbot added a comment.Oct 19 2016, 6:52 AM

Change 316611 merged by jenkins-bot:
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes.Oct 19 2016, 7:00 AM
gerritbot added a comment.Oct 19 2016, 3:47 PM

Change 316612 merged by jenkins-bot:
Fix videojs mode control bar in RTL

https://gerrit.wikimedia.org/r/316612

TheDJ closed this task as Resolved.Oct 31 2016, 8:18 PM
TheDJ assigned this task to • brooke.
TheDJ edited projects, added TimedMediaHandler; removed Patch-For-Review.
TheDJ moved this task from To sort to Done on the TimedMediaHandler board.
Aklapper removed a project: TimedMediaHandler.Nov 7 2019, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits