Page MenuHomePhabricator
Create Task
Maniphest T148419

Patch adding caches to MediaWikiServices caused Cognate services to not correctly register
Closed, ResolvedPublic
Actions

Description

A combination of https://gerrit.wikimedia.org/r/#/c/313456/4 and https://gerrit.wikimedia.org/r/#/c/313351/3 result in services in the Cognate extension to not correctly get registered.

This can be seen in the tests or while loading a page on a wiki with the extension enabled.

6) Cognate\Tests\ServiceWiringTest::testServiceWiring with data set #0 ('CognateStore', 'Cognate\CognateStore')
MediaWiki\Services\NoSuchServiceException: No such service: CognateStore

mediawiki\includes\services\ServiceContainer.php:364
mediawiki\includes\services\ServiceContainer.php:344
mediawiki\extensions\Cognate\tests\phpunit\ServiceWiringTest.php:26
mediawiki\tests\phpunit\MediaWikiTestCase.php:392
mediawiki\maintenance\doMaintenance.php:110

Details

SubjectRepoBranchLines +/-
MWServices load new ServiceWiringFiles after ExtRegistry loadmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Addshore created this task.Oct 17 2016, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2016, 1:55 PM
Addshore added a project: Wikidata.Oct 17 2016, 1:55 PM
Addshore added a project: Cognate.Oct 17 2016, 2:15 PM
aaron added a comment.Oct 17 2016, 11:02 PM

Are they are more useful/direct traces?

gerritbot subscribed.Oct 18 2016, 10:51 AM

Change 316540 had a related patch set uploaded (by Addshore):
MWServices load new ServiceWiringFiles after ExtRegistry load

https://gerrit.wikimedia.org/r/316540

gerritbot added a project: Patch-For-Review.Oct 18 2016, 10:51 AM
Addshore claimed this task.Oct 18 2016, 10:57 AM
Addshore added projects: User-Addshore, WMDE-QWERTY-Team-Experimental-Sprint.
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.
Addshore moved this task from Proposed to Review on the WMDE-QWERTY-Team-Experimental-Sprint board.
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 18 2016, 1:07 PM
gerritbot added a comment.Oct 18 2016, 6:31 PM

Change 316540 merged by jenkins-bot:
MWServices load new ServiceWiringFiles after ExtRegistry load

https://gerrit.wikimedia.org/r/316540

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes.Oct 18 2016, 7:00 PM
Addshore closed this task as Resolved.Oct 19 2016, 2:10 PM
Addshore moved this task from Review to Done on the WMDE-QWERTY-Team-Experimental-Sprint board.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team-Experimental-Sprint board.Oct 25 2016, 12:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits