Page MenuHomePhabricator
Create Task
Maniphest T147973

Amazon donation order ids are useless when generated by processor
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

They're getting an AUTHORIZE_ prefix somewhere, and the donation import can't find the pending data

Details

SubjectRepoBranchLines +/-
Fix check for Amazon-generated IDswikimedia/fundraising/SmashPigmaster+15 -1
Fix Amazon order IDs for manual captureswikimedia/fundraising/SmashPigmaster+109 -18
DRY finding OrderReferenceId, get_class() -> instanceOfwikimedia/fundraising/SmashPigmaster+87 -35
Fix merchant order ID on order referencemediawiki/extensions/DonationInterfacemaster+2 -2
Customize query in gerrit

Event Timeline

Ejegg created this task.Oct 12 2016, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2016, 9:45 PM
• DStrine moved this task from Triage to Current Sprint & Completed in Q1 1617 on the Fundraising-Backlog board.Oct 12 2016, 10:36 PM
• DStrine added a project: Fundraising Sprint Testing on Production.Oct 12 2016, 11:05 PM
• DStrine moved this task from Current Sprint & Completed in Q1 1617 to Completed in Q2 1617 on the Fundraising-Backlog board.Oct 13 2016, 4:42 PM
Ejegg claimed this task.Oct 14 2016, 8:52 PM
Ejegg triaged this task as High priority.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Testing on Production board.
Ejegg set the point value for this task to 2.
Ejegg added a comment.Oct 14 2016, 10:02 PM

Everything looks OK from our side, sent an email to our contacts there.

Ejegg renamed this task from Amazon donation order ids are being set incorrectly by the listener to Amazon donation order ids are useless when generated by processor.Oct 18 2016, 12:22 AM
gerritbot subscribed.Oct 18 2016, 12:25 AM

Change 316503 had a related patch set uploaded (by Ejegg):
Fix merchant order ID on order reference

https://gerrit.wikimedia.org/r/316503

gerritbot added a project: Patch-For-Review.Oct 18 2016, 12:26 AM
Ejegg added a comment.Oct 18 2016, 12:27 AM

These are orders that were captured manually via the console. Our call to setOrderReferenceDetails used the wrong parameter name for seller order ID, so that entity didn't have our ID attached. Hoping the above patch fixing that will make the ID carry forward through authorization and capture.

TODO: make sure we're not charging people who think their donation failed.

Ejegg moved this task from Doing to Review on the Fundraising Sprint Testing on Production board.Oct 18 2016, 12:28 AM
gerritbot added a comment.Oct 18 2016, 5:44 AM

Change 316503 merged by jenkins-bot:
Fix merchant order ID on order reference

https://gerrit.wikimedia.org/r/316503

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 18 2016, 6:00 AM
Ejegg moved this task from Review to Done on the Fundraising Sprint Testing on Production board.Oct 18 2016, 4:58 PM
• DStrine added a project: Fundraising Sprint Unbreaking Now.Oct 26 2016, 10:49 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Unbreaking Now board.Oct 26 2016, 11:06 PM
Ejegg added a comment.Oct 27 2016, 12:39 AM

Just monitoring to see if any more of these arise - our Amazon contact said he didn't think this fix would do it, but I do see captures getting the same reference ID as the associated authorization.

Ejegg moved this task from Done to Doing on the Fundraising Sprint Unbreaking Now board.Nov 9 2016, 7:44 PM
• DStrine added a project: Fundraising Sprint Value Subtracting.Nov 9 2016, 11:56 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Value Subtracting board.Nov 10 2016, 12:10 AM
gerritbot added a comment.Nov 10 2016, 2:01 AM

Change 320710 had a related patch set uploaded (by Ejegg):
WIP Fix Amazon order IDs for manual captures

https://gerrit.wikimedia.org/r/320710

gerritbot added a comment.Nov 10 2016, 7:46 PM

Change 320833 had a related patch set uploaded (by Ejegg):
DRY finding OrderReferenceId, get_class() -> instanceOf

https://gerrit.wikimedia.org/r/320833

Ejegg moved this task from Doing to Review on the Fundraising Sprint Value Subtracting board.Nov 10 2016, 8:31 PM
gerritbot added a comment.Nov 17 2016, 7:25 PM

Change 320833 merged by jenkins-bot:
DRY finding OrderReferenceId, get_class() -> instanceOf

https://gerrit.wikimedia.org/r/320833

gerritbot added a comment.Nov 17 2016, 7:26 PM

Change 320710 merged by jenkins-bot:
Fix Amazon order IDs for manual captures

https://gerrit.wikimedia.org/r/320710

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Value Subtracting board.Nov 17 2016, 8:53 PM
gerritbot added a comment.Nov 17 2016, 10:10 PM

Change 322203 had a related patch set uploaded (by Ejegg):
Fix check for Amazon-generated IDs

https://gerrit.wikimedia.org/r/322203

gerritbot added a comment.Nov 17 2016, 10:16 PM

Change 322203 merged by jenkins-bot:
Fix check for Amazon-generated IDs

https://gerrit.wikimedia.org/r/322203

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Value Subtracting board.Nov 17 2016, 10:26 PM
Ejegg closed this task as Resolved.Nov 17 2016, 10:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits