Page MenuHomePhabricator
Create Task
Maniphest T147956

Regression: MainPage margins are off
Closed, ResolvedPublic
Actions

Description

Ensure you are anon and in stable, visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page

Screen Shot 2016-10-12 at 11.51.45 AM.png (663×950 px, 116 KB)

Notice the additional padding at the bottom of the header and the lack of margin on the content

This code is live on https://m.mediawiki.org/wiki/MediaWiki and will soon be live on English Wikipedia
This only impacts the main page

Details

SubjectRepoBranchLines +/-
Avoid margin collapsingmediawiki/extensions/MobileFrontendmaster+2 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 12 2016, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2016, 6:53 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-83-Y? board.Oct 12 2016, 7:14 PM
Jdlrobson added a project: Unplanned-Sprint-Work.
Jdlrobson claimed this task.Oct 12 2016, 8:15 PM

It appears to be related to the new footer. A git bisect shows the issue was introduced in I1199dd3bd4d0ea23687abcf0c763b61e699f0651

gerritbot subscribed.Oct 12 2016, 8:25 PM

Change 315565 had a related patch set uploaded (by Jdlrobson):
Avoid margin collapsing

https://gerrit.wikimedia.org/r/315565

gerritbot added a project: Patch-For-Review.Oct 12 2016, 8:25 PM
Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 12 2016, 8:25 PM
• jhobs added a project: Web-Team-Backlog.Oct 13 2016, 5:17 PM
Jdlrobson added subscribers: • Nirzar, • bmansurov.Oct 13 2016, 7:26 PM

@Nirzar today is the last day we can stop this going to production. I am happy to deploy this today if you do. Otherwise the bug will be present till at the very earliest Monday. Please let me know if you consider this a big problem. cc @bmansurov

• Nirzar added a comment.Oct 13 2016, 7:37 PM

Thought about it a lot. i think we can live with for couple of days.

ovasileva triaged this task as High priority.Oct 13 2016, 8:23 PM
ovasileva moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.
• bmansurov added a comment.Oct 13 2016, 9:21 PM

@Nirzar, can you reply to Jon's question at https://gerrit.wikimedia.org/r/#/c/315565/1/resources/skins.minerva.base.styles/ui.less

• Nirzar added a comment.Oct 13 2016, 11:08 PM

@bmansurov commented

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-83-Y? board.Oct 14 2016, 3:16 PM
gerritbot added a comment.Oct 14 2016, 3:20 PM

Change 315565 merged by jenkins-bot:
Avoid margin collapsing

https://gerrit.wikimedia.org/r/315565

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 14 2016, 4:00 PM
• bmansurov reassigned this task from Jdlrobson to • Nirzar.Oct 14 2016, 5:52 PM

@Nirzar, can you sign off: https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?

• Nirzar added a comment.Oct 14 2016, 9:21 PM

@bmansurov Looks good

• bmansurov closed this task as Resolved.Oct 14 2016, 9:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits