Page MenuHomePhabricator
Create Task
Maniphest T146923

Replace usages of mw-ui-primary and mw-ui-constructive with mw-ui-progressive
Closed, ResolvedPublic
Actions

Description

In various places we are using these deprecated classes. Let's stop doing this immediately by moving to use mw-ui-progressive to stop further confusion.
Compare M101

See

Core

Skins

Using mw-ui-primary

  • Timeless (this seems to maintain its own unused version of this class)
  • Tempo (this seems to maintain its own unused version of this class)

Extensions

Using mw-ui-constructive and mw-ui-primary

Using mw-ui-primary

Using mw-ui-constructive

Details

SubjectRepoBranchLines +/-
mediawiki.UI: Document explicitly about deprecated .mw-ui-constructivemediawiki/coremaster+11 -11
Replace deprecated .mw-ui-constructive class with .mw-ui-progressivemediawiki/extensions/GuidedTourmaster+4 -6
Replace deprecated `constructive` with `progressive`mediawiki/coremaster+19 -33
Replace deprecated .mw-ui-constructive with .mw-ui-progressivemediawiki/extensions/ContentTranslationmaster+3 -3
Replace deprecated .mw-ui-constructive with .mw-ui-progressivemediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Replace deprecated .mw-ui-constructive with .mw-ui-progressivemediawiki/extensions/Flowmaster+43 -51
Use mw-ui-progressive on constructive buttonsmediawiki/extensions/MobileFrontendmaster+5 -3
Remove styling for .mw-ui-primarymediawiki/skins/Timelessmaster+0 -2
Remove styling for .mw-ui-constructivemediawiki/skins/Timelessmaster+0 -3
Use mw-ui-progressive instead of constructivemediawiki/extensions/Thanksmaster+2 -2
Use mw-ui-progressive rather than deprecated mw-ui-primarymediawiki/extensions/Petitionmaster+1 -1
Use mw-ui-progressive instead of constructivemediawiki/extensions/WikiLovemaster+1 -1
settings: Use mw-ui-progressive instead of progressive buttonsmediawiki/extensions/Popupsmaster+3 -3
Use mw-ui-progressive on constructive buttonmediawiki/extensions/TwnMainPagemaster+1 -1
Use mw-ui-progressive CSS class for buttonsmediawiki/extensions/OAuthmaster+2 -2
Use mw-ui-progressive for button classesmediawiki/extensions/CentralAuthmaster+3 -3
Migrate away from deprecated mw-ui-constructive and mw-ui-primary classesmediawiki/extensions/Translatemaster+5 -5
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot subscribed.Sep 28 2016, 6:04 PM

Change 313227 had a related patch set uploaded (by Jdlrobson):
Migrate away from deprecated mw-ui-constructive and mw-ui-primary classes

https://gerrit.wikimedia.org/r/313227

gerritbot added a project: Patch-For-Review.Sep 28 2016, 6:04 PM
gerritbot added a comment.Sep 28 2016, 6:07 PM

Change 313228 had a related patch set uploaded (by Jdlrobson):
Use mw-ui-progressive on constructive buttons

https://gerrit.wikimedia.org/r/313228

Jdlrobson updated the task description. (Show Details)Sep 28 2016, 6:08 PM
gerritbot added a comment.Sep 28 2016, 6:26 PM

Change 313227 merged by jenkins-bot:
Migrate away from deprecated mw-ui-constructive and mw-ui-primary classes

https://gerrit.wikimedia.org/r/313227

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 28 2016, 7:00 PM
matmarex updated the task description. (Show Details)Sep 28 2016, 8:27 PM
Jdlrobson added a project: Web-Team-Backlog.Sep 28 2016, 8:46 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 28 2016, 8:49 PM

Change 313312 had a related patch set uploaded (by Jdlrobson):
Use mw-ui-progressive for button classes

https://gerrit.wikimedia.org/r/313312

Jdlrobson updated the task description. (Show Details)Sep 28 2016, 8:50 PM
gerritbot added a comment.Sep 28 2016, 8:55 PM

Change 313313 had a related patch set uploaded (by Jdlrobson):
Use mw-ui-progressive for buttons

https://gerrit.wikimedia.org/r/313313

gerritbot added a comment.Sep 28 2016, 8:55 PM

Change 313312 merged by jenkins-bot:
Use mw-ui-progressive for button classes

https://gerrit.wikimedia.org/r/313312

Jdlrobson updated the task description. (Show Details)Sep 28 2016, 8:55 PM
gerritbot added a comment.Sep 28 2016, 8:57 PM

Change 313314 had a related patch set uploaded (by Jdlrobson):
Use mw-ui-progressive rather than deprecated mw-ui-primary

https://gerrit.wikimedia.org/r/313314

Jdlrobson updated the task description. (Show Details)Sep 28 2016, 8:58 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Sep 28 2016, 9:02 PM
gerritbot added a comment.Sep 28 2016, 11:49 PM

Change 313313 merged by jenkins-bot:
Use mw-ui-progressive CSS class for buttons

https://gerrit.wikimedia.org/r/313313

Jdlrobson updated the task description. (Show Details)Sep 29 2016, 1:27 AM
gerritbot added a comment.Sep 29 2016, 1:16 PM

Change 313391 had a related patch set uploaded (by Prtksxna):
settings: Use mw-ui-progressive instead of progressive buttons

https://gerrit.wikimedia.org/r/313391

gerritbot added a comment.Sep 29 2016, 1:17 PM

Change 313392 had a related patch set uploaded (by Nikerabbit):
Use mw-ui-progressive on constructive button

https://gerrit.wikimedia.org/r/313392

Nikerabbit updated the task description. (Show Details)Sep 29 2016, 1:17 PM
• Prtksxna updated the task description. (Show Details)Sep 29 2016, 1:18 PM
gerritbot added a comment.Sep 29 2016, 1:22 PM

Change 313394 had a related patch set uploaded (by Prtksxna):
Use mw-ui-progressive instead of constructive

https://gerrit.wikimedia.org/r/313394

• Prtksxna updated the task description. (Show Details)Sep 29 2016, 1:23 PM
gerritbot added a comment.Sep 29 2016, 1:28 PM

Change 313396 had a related patch set uploaded (by Prtksxna):
Remove styling for .mw-ui-constructive

https://gerrit.wikimedia.org/r/313396

• Prtksxna updated the task description. (Show Details)Sep 29 2016, 1:30 PM
gerritbot added a comment.Sep 29 2016, 1:35 PM

Change 313397 had a related patch set uploaded (by Prtksxna):
Use mw-ui-progressive instead of constructive

https://gerrit.wikimedia.org/r/313397

• Prtksxna updated the task description. (Show Details)Sep 29 2016, 1:35 PM
• Prtksxna subscribed.
gerritbot added a comment.Sep 29 2016, 2:51 PM

Change 313396 merged by jenkins-bot:
Remove styling for .mw-ui-constructive

https://gerrit.wikimedia.org/r/313396

• Prtksxna updated the task description. (Show Details)Sep 29 2016, 2:52 PM
Jdlrobson updated the task description. (Show Details)Sep 29 2016, 4:10 PM
gerritbot added a comment.Sep 29 2016, 4:16 PM

Change 313391 merged by jenkins-bot:
settings: Use mw-ui-progressive instead of progressive buttons

https://gerrit.wikimedia.org/r/313391

gerritbot added a comment.Sep 29 2016, 4:16 PM

Change 313392 merged by jenkins-bot:
Use mw-ui-progressive on constructive button

https://gerrit.wikimedia.org/r/313392

• Prtksxna updated the task description. (Show Details)Sep 29 2016, 4:32 PM
• jhobs triaged this task as Medium priority.Sep 29 2016, 5:14 PM
• jhobs added a project: Reading-Web-Sprint-82-Xpect-Rspec.
• jhobs moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-82-Xpect-Rspec board.
• jhobs added a project: Unplanned-Sprint-Work.
• jhobs updated the task description. (Show Details)
gerritbot added a comment.Sep 29 2016, 5:33 PM

Change 313397 merged by jenkins-bot:
Use mw-ui-progressive instead of constructive

https://gerrit.wikimedia.org/r/313397

gerritbot added a comment.Sep 29 2016, 5:38 PM

Change 313314 merged by jenkins-bot:
Use mw-ui-progressive rather than deprecated mw-ui-primary

https://gerrit.wikimedia.org/r/313314

Volker_E updated the task description. (Show Details)Sep 29 2016, 5:42 PM
Volker_E awarded a token.
Volker_E added a project: UI-Standardization-Kanban.
Volker_E subscribed.
Restricted Application added a project: UI-Standardization. · View Herald TranscriptSep 29 2016, 5:44 PM
gerritbot added a comment.Sep 29 2016, 5:49 PM

Change 313394 merged by jenkins-bot:
Use mw-ui-progressive instead of constructive

https://gerrit.wikimedia.org/r/313394

• bmansurov added subscribers: ovasileva, • bmansurov.Sep 29 2016, 5:59 PM

@ovasileva, how did this normal priority task get added to our sprint? Aren't there more important tasks that we can work on?

gerritbot added a comment.Sep 29 2016, 6:01 PM

Change 313443 had a related patch set uploaded (by Prtksxna):
Remove styling for .mw-ui-primary

https://gerrit.wikimedia.org/r/313443

gerritbot added a comment.Sep 29 2016, 6:45 PM

Change 313443 merged by jenkins-bot:
Remove styling for .mw-ui-primary

https://gerrit.wikimedia.org/r/313443

Volker_E updated the task description. (Show Details)Sep 29 2016, 6:46 PM
matmarex updated the task description. (Show Details)Sep 29 2016, 6:55 PM
gerritbot added a comment.Sep 29 2016, 7:58 PM

Change 313228 merged by jenkins-bot:
Use mw-ui-progressive on constructive buttons

https://gerrit.wikimedia.org/r/313228

MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Sep 29 2016, 8:09 PM
Volker_E updated the task description. (Show Details)Sep 29 2016, 9:22 PM
gerritbot added a comment.Sep 29 2016, 10:02 PM

Change 313513 had a related patch set uploaded (by VolkerE):
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313513

Volker_E updated the task description. (Show Details)Sep 29 2016, 10:03 PM
gerritbot added a comment.Sep 29 2016, 10:26 PM

Change 313517 had a related patch set uploaded (by VolkerE):
Replace deprecated .mw-ui-constructive class with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313517

Volker_E updated the task description. (Show Details)Sep 29 2016, 10:28 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Sep 29 2016, 10:37 PM

Change 313520 had a related patch set uploaded (by VolkerE):
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313520

Volker_E updated the task description. (Show Details)Sep 29 2016, 10:38 PM
gerritbot added a comment.Sep 29 2016, 10:59 PM

Change 313528 had a related patch set uploaded (by VolkerE):
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313528

Volker_E updated the task description. (Show Details)Sep 29 2016, 11:00 PM
• Catrope mentioned this in T147038: "This topic has now been added to your watchlist" does not appear in Chrome.Sep 29 2016, 11:26 PM
gerritbot added a comment.Sep 29 2016, 11:35 PM

Change 313513 merged by jenkins-bot:
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313513

Jdlrobson removed projects: Reading-Web-Sprint-82-Xpect-Rspec, Web-Team-Backlog.Sep 29 2016, 11:56 PM
Volker_E updated the task description. (Show Details)Sep 30 2016, 12:59 AM
gerritbot added a comment.Sep 30 2016, 4:03 PM

Change 313528 merged by jenkins-bot:
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313528

Volker_E updated the task description. (Show Details)Sep 30 2016, 5:29 PM
gerritbot added a comment.Sep 30 2016, 8:21 PM

Change 313617 had a related patch set uploaded (by VolkerE):
Replace deprecated constructive with progressive

https://gerrit.wikimedia.org/r/313617

Volker_E updated the task description. (Show Details)Sep 30 2016, 8:22 PM
gerritbot added a comment.Sep 30 2016, 9:45 PM

Change 313617 merged by jenkins-bot:
Replace deprecated constructive with progressive

https://gerrit.wikimedia.org/r/313617

ReleaseTaggerBot added a project: MW-1.28-release-notes.Sep 30 2016, 10:00 PM
Volker_E updated the task description. (Show Details)Sep 30 2016, 10:03 PM
gerritbot added a comment.Oct 3 2016, 3:42 AM

Change 313520 merged by jenkins-bot:
Replace deprecated .mw-ui-constructive with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313520

Volker_E updated the task description. (Show Details)Oct 3 2016, 5:20 PM
gerritbot added a comment.Oct 10 2016, 9:11 PM

Change 313517 merged by jenkins-bot:
Replace deprecated .mw-ui-constructive class with .mw-ui-progressive

https://gerrit.wikimedia.org/r/313517

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 10 2016, 10:00 PM
Volker_E moved this task from Backlog to Doing… on the UI-Standardization-Kanban board.Oct 11 2016, 2:17 AM
Volker_E updated the task description. (Show Details)Oct 11 2016, 2:53 AM
gerritbot added a comment.Oct 11 2016, 3:20 AM

Change 315197 had a related patch set uploaded (by VolkerE):
mediawiki.UI: Document explicitly about deprecated .mw-ui-constructive

https://gerrit.wikimedia.org/r/315197

Volker_E updated the task description. (Show Details)Oct 11 2016, 3:29 AM
gerritbot added a comment.Oct 11 2016, 4:01 PM

Change 315197 merged by jenkins-bot:
mediawiki.UI: Document explicitly about deprecated .mw-ui-constructive

https://gerrit.wikimedia.org/r/315197

Volker_E updated the task description. (Show Details)Oct 11 2016, 5:34 PM
Jdlrobson closed this task as Resolved.Oct 11 2016, 8:30 PM
Jdlrobson claimed this task.

I think we're done. Thanks to all that helped!
Please reopen if we've missed anything.

• Prtksxna awarded a token.Oct 12 2016, 4:24 AM
Volker_E removed a project: Patch-For-Review.Oct 12 2016, 7:38 AM
Volker_E moved this task from Doing… to Done on the UI-Standardization-Kanban board.
Volker_E mentioned this in T128577: Apex's constructive buttons are not visually distinct.Jan 4 2017, 2:59 AM
Volker_E mentioned this in T155203: Remove deprecated `.mw-ui-constructive` modifier class for anchors & text.Jan 12 2017, 11:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits