Navigate to http://localhost:8888/w/index.php?title=Special:Watchlist&filter=other&watchlistview=feed&mobileaction=beta
You'll notice due to the fact there is no last modifier bar, there is no top border on the footer.
There should be right?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Move border top from last modifier bar to footer container | mediawiki/extensions/MobileFrontend | master | +1 -1 |
Related Objects
Related Objects
Event Timeline
Comment Actions
the top border should be part of the footer in the first place. so yes. the recent changes bar should not have top border.
Comment Actions
Change 313216 had a related patch set uploaded (by Jdlrobson):
Move border top from last modifier bar to footer container
Comment Actions
From my review:
This LGTM.
I tested this by visiting a number of regular article pages and a handful of special pages, i.e. Special:History and Special:Watchlist, and observed that the footer had a top border on all of them.
Comment Actions
Change 313216 merged by jenkins-bot:
Move border top from last modifier bar to footer container
Comment Actions
@Nirzar: rEMFRfd62bb6b841a: Move border top from last modifier bar to footer container has been deployed to the Beta Cluster. Take a look at https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist?mobileaction=beta f'rinstance.
Comment Actions
@Jdlrobson This is currently a subtask but AFAICT it's a bug. Should it have an estimate?
Comment Actions
@phuedx @Jdlrobson estimate if it's an issue in and of itself, no estimate if it's something that occurred as part of another estimated ticket this sprint.