Page MenuHomePhabricator
Create Task
Maniphest T146697

Should we keep StashEdit logs in AbuseFilter?
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Roughly half of messages sent to logstash are from AbuseFilter writing to the StashEdit log bucket. That cause logs to be emitted for each filterAction calls.

The info log has been added by e91939fb3fdc93842ec64541302a2157a377b440 for T137698.

It does not seem to serve much purpose in production nowadays. Can we change them to debug and raise production login for StashEdit from debug to info?

A similar request for api-feature-usage T146472

Details

SubjectRepoBranchLines +/-
Lower stash logging to debug()mediawiki/extensions/AbuseFiltermaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Sep 26 2016, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2016, 8:43 PM
hashar updated the task description. (Show Details)Sep 26 2016, 8:45 PM
gerritbot subscribed.Sep 26 2016, 10:21 PM

Change 312942 had a related patch set uploaded (by Aaron Schulz):
Lower stash logging to debug()

https://gerrit.wikimedia.org/r/312942

gerritbot added a project: Patch-For-Review.Sep 26 2016, 10:21 PM
hashar moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Sep 27 2016, 7:16 PM
gerritbot added a comment.Sep 27 2016, 7:21 PM

Change 312942 merged by jenkins-bot:
Lower stash logging to debug()

https://gerrit.wikimedia.org/r/312942

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 27 2016, 8:00 PM
hashar closed this task as Resolved.Oct 13 2016, 9:41 PM
hashar assigned this task to aaron.

The most spasming message has been lowered from INFO to DEBUG which is not logged. That dropped the rate of logs from 4 millions per day to ~ 1.5 millions.

All set. Thank you @aaron

Krinkle moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:33 PM
fgiunchedi added a project: observability.Aug 19 2019, 2:27 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits