Page MenuHomePhabricator
Create Task
Maniphest T146661

[Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Cannot add images with VisualEditor, showing error "TypeError: xhr.abort is not a function", causing VE to crash

Screen Shot 2016-09-26 at 5.19.14 PM.png (725×1 px, 304 KB)

Details

SubjectRepoBranchLines +/-
Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP"mediawiki/extensions/VisualEditormaster+22 -8
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Sep 26 2016, 4:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2016, 4:19 PM
matmarex triaged this task as Unbreak Now! priority.Sep 26 2016, 4:28 PM
matmarex added subscribers: Esanders, matmarex.

This is because https://gerrit.wikimedia.org/r/#/c/309767/ was merged without merging https://gerrit.wikimedia.org/r/#/c/309766/.

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptSep 26 2016, 4:28 PM
gerritbot subscribed.Sep 26 2016, 6:49 PM

Change 312856 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP"

https://gerrit.wikimedia.org/r/312856

gerritbot added a project: Patch-For-Review.Sep 26 2016, 6:49 PM
gerritbot added a comment.Sep 26 2016, 6:55 PM

Change 312856 merged by jenkins-bot:
Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP"

https://gerrit.wikimedia.org/r/312856

matmarex added a comment.Sep 26 2016, 6:55 PM

That revert should fix the issue.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 26 2016, 7:00 PM
greg added a project: Beta-Cluster-reproducible.Sep 26 2016, 10:56 PM
greg subscribed.

The screenshot shows this is on Beta Cluster. This isn't in production, I presume/hope, right? :)

matmarex added a comment.Sep 26 2016, 11:56 PM

Right.

Ryasmeen added a comment.Sep 27 2016, 1:15 PM
This comment was removed by Ryasmeen.
Ryasmeen closed this task as Resolved.Sep 27 2016, 1:16 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Oct 3 2016, 5:10 PM
Jdforrester-WMF set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits