JavaScript error from ext.cleanchanges.uls on Special:RecentChanges
Closed, ResolvedPublic
Actions

Description

For example in https://wiki.aineetonkulttuuriperinto.fi/wiki/Toiminnot:Tuoreet_muutokset

Happens when language filter is not in use. Code calls unconditionally $trigger.val(). Most likely the code should not run at all in this case.

Exception in load-callback in module ext.uls.mediawiki:
TypeError: Cannot read property 'replace' of undefined

Details

	Subject	Repo	Branch	Lines +/-
	Do not load ext.cleanchanges.uls unnecessarily	mediawiki/extensions/CleanChanges	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned Here: rECLCfeed6810b0f4: Avoid JavaScript error on Special:Watchlist

Event Timeline

Nikerabbit created this task.Sep 23 2016, 1:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2016, 1:58 PM

Nikerabbit renamed this task from JavaScript error from ext.cleanchanges.url on Special:RecentChanges to JavaScript error from ext.cleanchanges.uls on Special:RecentChanges.Sep 23 2016, 1:59 PM

Nikerabbit moved this task from Backlog to 2016.10 on the MediaWiki Language Extension Bundle board.Sep 23 2016, 2:02 PM

This was actually fixed feed6810b0f4ffbfa15a2981e3f4bff8d3efbf16 but the linked site is running old version, I have to check why. Anyway, I can improve this.

Change 315646 had a related patch set uploaded (by Nikerabbit):
Do not load ext.cleanchanges.uls unnecessarily

https://gerrit.wikimedia.org/r/315646

gerritbot added a project: Patch-For-Review.Oct 13 2016, 8:39 AM

Nikerabbit claimed this task.Oct 13 2016, 8:40 AM

Nikerabbit removed a project: Regression.

Nikerabbit added a project: Language-Q2-2016-17 Sprint 1.

Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptOct 13 2016, 8:40 AM

Nikerabbit triaged this task as Low priority.Oct 13 2016, 8:42 AM

Arrbee moved this task from Backlog to Unplanned/General i18n on the Language-Engineering October-December 2016 board.Oct 14 2016, 5:48 AM

Change 315646 merged by jenkins-bot:
Do not load ext.cleanchanges.uls unnecessarily

https://gerrit.wikimedia.org/r/315646

Nikerabbit moved this task from Backlog to QA on the Language-Q2-2016-17 Sprint 1 board.Oct 20 2016, 11:55 PM