Page MenuHomePhabricator
Create Task
Maniphest T146353

Location with NaN in uploads of UploadWizard
Closed, ResolvedPublic
Actions

Description

Since some weeks there is a constant stream of uploads performed with the UploadWizard which contain the Location template with NaN value which is obiously wrong. Examples: https://commons.wikimedia.org/wiki/File:Patan_Durbar_Square_Premises_2016_32.jpg, or https://commons.wikimedia.org/wiki/File:Darasbari_Mosque_01.jpg. These uploads are filling the following category: https://commons.wikimedia.org/wiki/Category:Media_with_erroneous_locations.

Details

SubjectRepoBranchLines +/-
Fix NaN location inputmediawiki/extensions/UploadWizardmaster+4 -4
Customize query in gerrit

Event Timeline

Aschroet created this task.Sep 22 2016, 8:54 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 22 2016, 8:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aschroet renamed this task from Location with NaN to Location with NaN in uploads of UploadWizard.Sep 22 2016, 8:55 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 22 2016, 8:55 AM
matthiasmullie claimed this task.Sep 22 2016, 9:05 AM
matthiasmullie moved this task from Untriaged to Needs code review on the Multimedia board.Sep 22 2016, 10:05 AM
gerritbot subscribed.Sep 22 2016, 10:09 AM

Change 312220 had a related patch set uploaded (by Matthias Mullie):
Fix NaN location input

https://gerrit.wikimedia.org/r/312220

gerritbot added a project: Patch-For-Review.Sep 22 2016, 10:09 AM
matmarex closed this task as Resolved.Sep 22 2016, 7:11 PM
matmarex removed a project: Patch-For-Review.
matmarex subscribed.

The fix has been merged and will probably be deployed to Commons on Thursday next week, with MediaWiki version 1.28.0-wmf.21.

gerritbot added a comment.Sep 22 2016, 7:12 PM

Change 312220 merged by jenkins-bot:
Fix NaN location input

https://gerrit.wikimedia.org/r/312220

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 22 2016, 8:00 PM
Aschroet added a comment.Sep 22 2016, 8:26 PM

Thank you for the quick fix.

matmarex added a comment.Sep 22 2016, 10:07 PM

Actually, it will be the next next week (so Thursday, 7 October 2016), as there are no deployments planned next week due to Operations team's offsite meeting. Sorry.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits