Unable to view notifications in Echo
Closed, ResolvedPublic
Actions

Description

Caught by browser test and now blocking all MobileFrontend merges:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium/10247/console

Notifications overlay is broken on mobile site.
The error reported in the JS console is:
TypeError: Cannot read property 'bind' of undefined
and it seems to have been introduced by 1575e2bb7a2f686ba4fba71c19bfd70b4c18abc7

Side note: Should MobileFrontend run our browser test suite - this has happened a few times now.

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Convert 'seenTime' to a global property"	mediawiki/extensions/Echo	master	+103 -115
	Followup I67bcc4b34: Update call to global seenTime	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T145222: Images with dimensions expressed via styles are being loaded even when hidden
Mentioned Here: rECHO1575e2bb7a2f: Convert 'seenTime' to a global property

Event Timeline

Jdlrobson created this task.Sep 21 2016, 8:36 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 21 2016, 8:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 312105 had a related patch set uploaded (by Jdlrobson):
Revert "Convert 'seenTime' to a global property"

https://gerrit.wikimedia.org/r/312105

gerritbot added a project: Patch-For-Review.Sep 21 2016, 8:37 PM

Jdlrobson triaged this task as Unbreak Now! priority.Sep 21 2016, 8:37 PM

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptSep 21 2016, 8:37 PM

Jdlrobson mentioned this in T145222: Images with dimensions expressed via styles are being loaded even when hidden.Sep 21 2016, 8:40 PM

@Jdlrobson Should this be in the sprint? MobileFrontend + Patch-For-Review + your patch :)

Dealing with this right now. There's a small change we forgot to make when fixing global seen time - I'm submitting now. There's no need to revert the whole seenTime change.

Change 312112 had a related patch set uploaded (by Mooeypoo):
Followup I67bcc4b34: Update call to global seenTime

https://gerrit.wikimedia.org/r/312112

Mooeypoo claimed this task.Sep 21 2016, 8:53 PM

Mooeypoo edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collaboration-Team-Triage.

Mooeypoo moved this task from Untriaged to Needs Review on the Collab-Team-Q1-July-Sep-2016 board.

Change 312112 merged by jenkins-bot:
Followup I67bcc4b34: Update call to global seenTime

https://gerrit.wikimedia.org/r/312112

Fixed for me locally and seems to be passing tests. Can you confirm this is fixed, @Jdlrobson ? Can we abandon the revert patch?

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 21 2016, 10:00 PM

Checked in betalabs mobile

the Notification overlay has no problem with displaying
the latest build https://integration.wikimedia.org/ci/job/mwext-mw-selenium/ shows no problems
interesting, https://integration.wikimedia.org/ci/view/Selenium/job/selenium-MobileFrontend/ shows a continuous stretch of failing tests for 23 days. Are those tests are not monitored?

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 21 2016, 11:08 PM

Change 312105 abandoned by Jdlrobson:
Revert "Convert 'seenTime' to a global property"

Reason:
Feel free to abandon these in future. I never get offended by abandons and sometimes forget. :) thanks again for fixing so quickly!