Page MenuHomePhabricator
Create Task
Maniphest T146293

Remove .gitreview from MediaWiki and Extensions
Closed, ResolvedPublic
Actions

Description

Tweaking the .gitreview file is the most intensive part of make-wmf-branch.

Dropping the .gitreview file would be an ideal solution—allowing us to make the branch in gerrit; however it may result in unexpected behavior.

Since git-review version ̀1.25.0, it set up the tracking branch when a downloading a change and can be instructed to default to the tracked branch when sending a patch. Then:

  • In .git-review replace defaultbranch = xxxx with track =1
  • Get developers to use git-review 1.25.0 or later
  • Eventually get people to make that a global option with: git config --global --add gitreview.track 1

We will want to update doc and announce the requirement change with instruction to upgrade. See for T146293#2658764 details.

Details

SubjectRepoBranchLines +/-
.gitreview: Remove defaultbranchmediawiki/extensions/WikibaseStatementUpdatermaster+0 -1
Remove `defaultbranch=master` from .gitreviewwikimedia/portalsmaster+1 -1
Remove `defaultbranch=master` from .gitreviewoperations/software/puppet-compiler2.x+2 -1
.gitreview: Swap to track=1mediawiki/extensions/ArticleCreationWorkflowmaster+1 -1
.gitreview: Swap to track=1mediawiki/extensions/FileImportermaster+1 -1
.gitreview: Swap to track=1mediawiki/extensions/SecurityApimaster+0 -1
.gitreview: Swap to track=1mediawiki/extensions/FileExportermaster+2 -2
.gitreview: Swap to track=1data-values/value-viewmaster+1 -1
Switch .gitreview from defaultbranch to trackmediawiki/extensions/Whoopsmaster+1 -1
Stop mangling .gitreviewmediawiki/tools/releasemaster+0 -38
.gitreview: swapping defaultbranch for trackmediawiki/extensions/VisualEditormaster+1 -1
.gitreview: swapping defaultbranch for trackmediawiki/extensions/Validatormaster+1 -1
.gitreview: swapping defaultbranch for trackmediawiki/extensions/RandomImageByCategorymaster+2 -2
.gitreview: swapping defaultbranch for trackmediawiki/extensions/DonationInterfacemaster+1 -1
.gitreview: swapping defaultbranch for trackmediawiki/extensions/CategoryTagSortermaster+2 -2
Whoops, track not tracemediawiki/skins/Metrolookmaster+1 -1
Swapping defaultbranch for trackmediawiki/coremaster+1 -1
Swapping defaultbranch for trackmediawiki/vendormaster+1 -1
Swapping defaultbranch for trackmediawiki/skinsmaster+1 -1
Swapping defaultbranch for trackmediawiki/extensionsmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Vectormaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Truglassmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Tomasmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Timelessmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Tempomaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Synagonismmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Splashmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Schulenburgmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Refreshedmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Nostalgiamaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Nimbusmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/MonoBookmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Modernmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/MinervaNeuemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Maskmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/HasSomeColoursmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/GreyStuffmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Gamepressmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Examplemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Emptymaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/DuskToDawnmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Duskmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Donatemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/DeskMessMirroredmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/DeepSeamaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Daddiomaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/CustomPagemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/CologneBluemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Bouquetmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Blueprintmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/BlueSpiceSkinmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/BlueSkymaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/VectorV2master+1 -1
Swapping defaultbranch for tracemediawiki/skins/WPtouchmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/WoOgLeShadesmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/apexmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/eruditemaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/mediawiki-strappingmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/p2wikimaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/webplatformmaster+1 -1
Swapping defaultbranch for tracemediawiki/skins/Metrolookmaster+1 -1
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rEWSU6221112a301a: .gitreview: Remove defaultbranch
rEFILEEXPORT85de77235504: .gitreview: Swap to track=1
rESAP1fd43c6376b1: .gitreview: Swap to track=1
rEQSL4ae80ea7a879: Swapping defaultbranch for trace
rELTGf46d2d899700: Swapping defaultbranch for trace
rEMME8f4cb4589fce: Swapping defaultbranch for trace
rEMNLe9fd69b47398: Swapping defaultbranch for trace
rELNTd92764fc8d6a: Swapping defaultbranch for trace
rEMMH3c4e9c633122: Swapping defaultbranch for trace
rENBU24b67471183b: Swapping defaultbranch for trace
rENBVceb53cf52ecf: Swapping defaultbranch for trace
rEPRZ4c1a4dcfbb3d: Swapping defaultbranch for trace
rEOAL876090e5fe4d: Swapping defaultbranch for trace
rEEUSfee6453ede35: Swapping defaultbranch for trace
rESRD739a0e0244f6: Swapping defaultbranch for trace
rEWOPbc5717d728b0: Switch .gitreview from defaultbranch to track
rESSa4bab2cdae8b: Swapping defaultbranch for trace
rEPPdf4bc82e03bc: Swapping defaultbranch for trace
rEEDIa0c3fa36ed8d: Swapping defaultbranch for trace
rEMEM7c5bc0f1eabe: Swapping defaultbranch for trace
rEBHK0d6ddbc0b77d: Swapping defaultbranch for trace
R1899:53c6e13f0149: Swapping defaultbranch for trace
rETCCb35302936f62: Swapping defaultbranch for trace
rEPVJce7bf487d265: Swapping defaultbranch for trace
rEENFc6a77d258ada: Swapping defaultbranch for trace
rSEXAMPLE776f582d6ef0: Swapping defaultbranch for trace
rENUAC3d932b68a658: Swapping defaultbranch for trace
rEMET3bf332241226: Swapping defaultbranch for trace
rECOS97a6419a35d8: Swapping defaultbranch for trace
R1898:c1f2658f90d1: Swapping defaultbranch for trace
rEPCE88862b07c745: Swapping defaultbranch for trace
rEWBI113344601f9d: Swapping defaultbranch for trace
rEARAb0c730e9cec4: Swapping defaultbranch for trace
rERECa1bd3327f286: Swapping defaultbranch for trace
rENTF341ad6db20a2: Swapping defaultbranch for trace
R1896:71803320b737: Swapping defaultbranch for trace
rEPTQf90a35bdd117: Swapping defaultbranch for trace
R1902:44ef4026ee78: Swapping defaultbranch for trace
rESHH4a5918131490: Swapping defaultbranch for trace
rEIWSf3f00805ebec: Swapping defaultbranch for trace
rEUPEfeb4e4155e86: Swapping defaultbranch for trace
rEBSMfecb64157079: Swapping defaultbranch for trace
rEMWF4f90c4544d97: Swapping defaultbranch for trace
rEGCN41037c569120: Swapping defaultbranch for trace
rEQS6526cf32323f: Swapping defaultbranch for trace
rEWISdcb802eb1459: Swapping defaultbranch for trace
rEBOP09116665eb15: Swapping defaultbranch for trace
rEMWVcfecccec2ee6: Swapping defaultbranch for trace
R1894:c657d9fe82de: Swapping defaultbranch for trace
rEURDb4c72e6663fe: Swapping defaultbranch for trace
rECW8e979282ea2c: Swapping defaultbranch for trace
rEQGV6a7ca83bdb46: Swapping defaultbranch for trace
rEBSENC15d123566258: Swapping defaultbranch for trace
rEATHfbd12361cbee: Swapping defaultbranch for trace
rEXFA21b20d4ac126: Swapping defaultbranch for trace
rEWLE3570b836ced6: Swapping defaultbranch for trace
rEWPI346c04de6e46: Swapping defaultbranch for trace
rEWPE2fea9ca740ec: Swapping defaultbranch for trace
rEULKd2c81a997974: Swapping defaultbranch for trace
rESTLH09b2892e9cd4: Swapping defaultbranch for trace
rESCC06f1ba802f4e: Swapping defaultbranch for trace
rELGN7e004528f487: Swapping defaultbranch for trace
rEBSSMWCc921c0f4c55d: Swapping defaultbranch for trace
rERSL090e1c406638: Swapping defaultbranch for trace
rEPFM517b3f4e186b: Swapping defaultbranch for trace
rEOLYc094ce9b5e58: Swapping defaultbranch for trace
rEBSCe2770b5971cb: Swapping defaultbranch for trace
rECKT7446dea39785: Swapping defaultbranch for trace
rEEPS0d266a4cd692: Swapping defaultbranch for trace
rECOGa46bb165d32d: Swapping defaultbranch for trace
R1893:89cfad57c520: Swapping defaultbranch for trace
rSVEV32ce5cba2134: Swapping defaultbranch for trace

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• demon mentioned this in R1896:71803320b737: Swapping defaultbranch for trace.Oct 25 2016, 1:31 AM
• demon mentioned this in rENTF341ad6db20a2: Swapping defaultbranch for trace.
• demon mentioned this in rERECa1bd3327f286: Swapping defaultbranch for trace.Oct 25 2016, 1:36 AM
• demon mentioned this in rEARAb0c730e9cec4: Swapping defaultbranch for trace.Oct 25 2016, 1:39 AM
• demon mentioned this in rEWBI113344601f9d: Swapping defaultbranch for trace.Oct 25 2016, 1:46 AM
• demon mentioned this in rEPCE88862b07c745: Swapping defaultbranch for trace.Oct 25 2016, 1:50 AM
• demon mentioned this in R1898:c1f2658f90d1: Swapping defaultbranch for trace.Oct 25 2016, 1:57 AM
• demon mentioned this in rECOS97a6419a35d8: Swapping defaultbranch for trace.
• demon mentioned this in rEMET3bf332241226: Swapping defaultbranch for trace.Oct 25 2016, 2:02 AM
• demon mentioned this in rENUAC3d932b68a658: Swapping defaultbranch for trace.
• demon mentioned this in rSEXAMPLE776f582d6ef0: Swapping defaultbranch for trace.
• demon mentioned this in rEENFc6a77d258ada: Swapping defaultbranch for trace.Oct 25 2016, 2:11 AM
• demon mentioned this in rEPVJce7bf487d265: Swapping defaultbranch for trace.Oct 25 2016, 2:16 AM
• demon mentioned this in rETCCb35302936f62: Swapping defaultbranch for trace.Oct 25 2016, 2:21 AM
• demon mentioned this in R1899:53c6e13f0149: Swapping defaultbranch for trace.Oct 25 2016, 2:30 AM
• demon mentioned this in rEBHK0d6ddbc0b77d: Swapping defaultbranch for trace.
• demon mentioned this in rEMEM7c5bc0f1eabe: Swapping defaultbranch for trace.Oct 25 2016, 2:37 AM
• demon mentioned this in rEEDIa0c3fa36ed8d: Swapping defaultbranch for trace.Oct 25 2016, 2:39 AM
• demon mentioned this in rEPPdf4bc82e03bc: Swapping defaultbranch for trace.Oct 25 2016, 3:12 AM
• demon mentioned this in rESSa4bab2cdae8b: Swapping defaultbranch for trace.
hashar updated the task description. (Show Details)Oct 25 2016, 8:03 AM
hashar added a comment.Oct 25 2016, 8:43 AM

Note: a bunch of attached commits used trace=1 and were followed up with commits to change it to the proper track=1.

A few follow ups are needed but not much to worry about.

gerritbot added a comment.Oct 25 2016, 8:45 AM

Change 317771 had a related patch set uploaded (by Hashar):
Whoops, track not trace

https://gerrit.wikimedia.org/r/317771

gerritbot added a comment.Oct 25 2016, 8:47 AM

Change 317771 merged by jenkins-bot:
Whoops, track not trace

https://gerrit.wikimedia.org/r/317771

gerritbot added a comment.Oct 25 2016, 8:55 AM

Change 317731 had a related patch set uploaded (by Chad):
Stop mangling .gitreview

https://gerrit.wikimedia.org/r/317731

gerritbot added a comment.Oct 25 2016, 8:56 AM

Change 317774 had a related patch set uploaded (by Hashar):
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317774

gerritbot added a comment.Oct 25 2016, 8:57 AM

Change 317775 had a related patch set uploaded (by Hashar):
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317775

gerritbot added a comment.Oct 25 2016, 8:57 AM

Change 317777 had a related patch set uploaded (by Hashar):
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317777

gerritbot added a comment.Oct 25 2016, 8:58 AM

Change 317778 had a related patch set uploaded (by Hashar):
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317778

gerritbot added a comment.Oct 25 2016, 8:58 AM

Change 317779 had a related patch set uploaded (by Hashar):
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317779

gerritbot added a comment.Oct 25 2016, 9:09 AM

Change 317774 merged by jenkins-bot:
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317774

gerritbot added a comment.Oct 25 2016, 9:09 AM

Change 317775 merged by jenkins-bot:
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317775

gerritbot added a comment.Oct 25 2016, 9:09 AM

Change 317777 merged by jenkins-bot:
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317777

gerritbot added a comment.Oct 25 2016, 9:18 AM

Change 317779 merged by jenkins-bot:
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317779

gerritbot added a comment.Oct 25 2016, 9:18 AM

Change 317778 merged by jenkins-bot:
.gitreview: swapping defaultbranch for track

https://gerrit.wikimedia.org/r/317778

hashar added a comment.Oct 25 2016, 9:18 AM

All set; I have caught up the last remaining skins/extensions that got missed :]

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 25 2016, 6:00 PM
gerritbot added a comment.Oct 25 2016, 10:19 PM

Change 317731 merged by jenkins-bot:
Stop mangling .gitreview

https://gerrit.wikimedia.org/r/317731

Legoktm subscribed.Oct 29 2016, 1:09 AM

So....was anyone going to announce this? It did break git-review for me:

km@km-tp ~/p/v/m/e/Linter> git review -s
Cannot find symbolic reference
The following command failed with exit code 1
    "git symbolic-ref -q HEAD"
-----------------------

-----------------------

And I'm using git-review 1.25.0 from the official fedora repos.

thcipriani added a comment.Oct 31 2016, 8:03 PM
In T146293#2753584, @Legoktm wrote:

So....was anyone going to announce this?

{{done}}

It did break git-review for me:

km@km-tp ~/p/v/m/e/Linter> git review -s
Cannot find symbolic reference
The following command failed with exit code 1
    "git symbolic-ref -q HEAD"
-----------------------

-----------------------

And I'm using git-review 1.25.0 from the official fedora repos.

Hrm. The main reason I could think of for git symbolic-ref HEAD to fail is if HEAD is not pointed to a symbolic-ref, for instance in a detached-head state. HEAD not pointing to a ref probably would break track=1 so it seems like a reasonable exception.

• MZMcBride subscribed.Oct 31 2016, 10:58 PM
• Jonas subscribed.Nov 3 2016, 1:23 PM

Not sure if this is related but with cognate extension i get this error when downloading a patch:

/extensions/Cognate$ git review -d 316780
Cannot query patchset information
The following command failed with exit code 104
    "GET https://gerrit.wikimedia.org/changes/?q=316780&o=CURRENT_REVISION"
-----------------------
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /changes/ was not found on this server.</p>
</body></html>

-----------------------

(git-review version 1.25.0)

Paladox added a comment.EditedNov 3 2016, 3:14 PM

I think in the .gitreview file in the host section

Instead of doing

host=gerrit.wikimedia.org

We
Should do

host=gerrit.wikimedia.org/r

Paladox added a comment.Nov 3 2016, 3:18 PM
In T146293#2768233, @Jonas wrote:

Not sure if this is related but with cognate extension i get this error when downloading a patch:

/extensions/Cognate$ git review -d 316780
Cannot query patchset information
The following command failed with exit code 104
    "GET https://gerrit.wikimedia.org/changes/?q=316780&o=CURRENT_REVISION"
-----------------------
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /changes/ was not found on this server.</p>
</body></html>

-----------------------

(git-review version 1.25.0)

Hi that's because the link is wrong.

You are doing gerrit.wikimedia.org/change

Whereas it needs to be gerrit.wikimedia.org/r/change

So check in .git/config file and make sure that the gerrit link does gerrit.wikimedia.org/r

The /r prefix should be there ok

Addshore subscribed.Nov 3 2016, 3:46 PM

https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/.gitreview

Note: this doesn't happen to everyone :/

Paladox added a comment.Nov 3 2016, 4:08 PM
In T146293#2768631, @Addshore wrote:

https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/.gitreview

Note: this doesn't happen to everyone :/

Other users have reported this problem.

Maybe try in host gerrit.wikimedia.org/r ?

thcipriani added a comment.Nov 4 2016, 12:19 AM
In T146293#2768233, @Jonas wrote:

Not sure if this is related but with cognate extension i get this error when downloading a patch:

/extensions/Cognate$ git review -d 316780
Cannot query patchset information
The following command failed with exit code 104
    "GET https://gerrit.wikimedia.org/changes/?q=316780&o=CURRENT_REVISION"
-----------------------
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /changes/ was not found on this server.</p>
</body></html>

-----------------------

(git-review version 1.25.0)

When querying reviews, it seems that git-review uses the gerrit remote url to find that information:
https://github.com/openstack-infra/git-review/blob/master/git_review/cmd.py#L571

For whatever reason, it seems that the url for the gerrit git remote may be incorrect. What is the value of git remote get-url gerrit inside the cognate extension directory?

• Jonas added a comment.Nov 4 2016, 8:09 AM

What is the value of git remote get-url gerrit inside the cognate extension directory?

/extensions/Cognate$ git remote get-url gerrit
fatal: No such remote 'gerrit'
thcipriani added a comment.Nov 4 2016, 4:37 PM
In T146293#2770908, @Jonas wrote:

What is the value of git remote get-url gerrit inside the cognate extension directory?

/extensions/Cognate$ git remote get-url gerrit
fatal: No such remote 'gerrit'

heh, maybe this falls back...?

What about git remote -v?

hashar added a comment.Nov 4 2016, 4:52 PM

Also paste the output of git remote -v AND git-review -n --verbose that will show the underlying commands being used by git-review.

IIRC the issue happens when a repository has a push url set to https://. git-review then tries to use the REST API to connect and forge the URL solely based on the hostname (it miss the /r/).

The fix is to use ssh protocol for push. An example for my setup:

$ git remote -v
origin  https://gerrit.wikimedia.org/r/p/mediawiki/core.git (fetch)
origin  ssh://gerrit.wikimedia.org:29418/mediawiki/core.git (push)
$

If you still have a remote named gerrit I am pretty sure you can remove it. git-review 1.25.0 is supposed to use origin and on git-review -s will make the push url ssh://.

• Catrope subscribed.Nov 4 2016, 9:58 PM

git review -d is broken for me too, but only for https remotes. If I manually rewrite the remote to be ssh, it works.

In T146293#2772149, @hashar wrote:

Also paste the output of git remote -v AND git-review -n --verbose that will show the underlying commands being used by git-review.

Will do.

IIRC the issue happens when a repository has a push url set to https://. git-review then tries to use the REST API to connect and forge the URL solely based on the hostname (it miss the /r/).

That sounds right.

The fix is to use ssh protocol for push. An example for my setup:

$ git remote -v
origin  https://gerrit.wikimedia.org/r/p/mediawiki/core.git (fetch)
origin  ssh://gerrit.wikimedia.org:29418/mediawiki/core.git (push)
$

If you still have a remote named gerrit I am pretty sure you can remove it. git-review 1.25.0 is supposed to use origin and on git-review -s will make the push url ssh://.

That's not what I see though. I have https for both fetch and push, and git review -s doesn't change that. This is with extensions installed via vagrant, for reference.

[2016-11-04 14:57:11 PDT] catrope:~/vagrant/mediawiki/extensions/PageImages (master)$ git remote -v
origin	https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PageImages.git (fetch)
origin	https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PageImages.git (push)
[2016-11-04 14:57:13 PDT] catrope:~/vagrant/mediawiki/extensions/PageImages (master)$ git review -n --verbose -d 319651
2016-11-04 14:57:31.253760 Running: git symbolic-ref -q HEAD
2016-11-04 14:57:31.255941 Running: git for-each-ref --format=%(upstream) refs/heads/master
Following tracked origin/master rather than default origin/master
2016-11-04 14:57:31.258474 Running: git config --get gitreview.scheme
2016-11-04 14:57:31.260785 Running: git config --get gitreview.hostname
2016-11-04 14:57:31.263068 Running: git config --get gitreview.port
2016-11-04 14:57:31.265534 Running: git config --get gitreview.project
2016-11-04 14:57:31.268604 Running: git log --color=never --oneline HEAD^1..HEAD
2016-11-04 14:57:31.272505 Running: git remote
2016-11-04 14:57:31.275482 Running: git branch -a --color=never
2016-11-04 14:57:31.278540 Running: git config --get remote.origin.pushurl
2016-11-04 14:57:31.281717 Running: git config --get remote.origin.url
2016-11-04 14:57:31.285223 Running: git config --list
Found origin Push URL: https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PageImages.git
Query gerrit https://gerrit.wikimedia.org/changes/?q=319651&o=CURRENT_REVISION
2016-11-04 14:57:31.288082 Running: git config --bool --get http.sslVerify
Cannot query patchset information
The following command failed with exit code 104
    "GET https://gerrit.wikimedia.org/changes/?q=319651&o=CURRENT_REVISION"
-----------------------
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /changes/ was not found on this server.</p>
</body></html>

-----------------------
• Jonas added a comment.Nov 8 2016, 10:39 AM
In T146293#2773093, @Catrope wrote:

git review -d is broken for me too, but only for https remotes. If I manually rewrite the remote to be ssh, it works.

Thanks that is working for me!

• jhobs subscribed.Nov 9 2016, 2:39 PM
In T146293#2773093, @Catrope wrote:

git review -d is broken for me too, but only for https remotes. If I manually rewrite the remote to be ssh, it works.

I am also experiencing the issue @Jonas described, but changing the remote manually to ssh did not fix the problem for me. I also examined .git/config to see if I just needed to add /r to a URL, but the only URL was the remote for origin and it was fully formed (right down to the <extension>.git).

RandomDSdevel awarded a token.Nov 10 2016, 1:23 AM
gerritbot added a comment.May 21 2017, 8:47 PM

Change 355041 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[mediawiki/extensions/Whoops@master] Switch .gitreview from defaultbranch to track

https://gerrit.wikimedia.org/r/355041

Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team. · View Herald TranscriptMay 21 2017, 8:47 PM
QChris mentioned this in rEWOPbc5717d728b0: Switch .gitreview from defaultbranch to track.May 21 2017, 8:49 PM
gerritbot added a comment.May 22 2017, 10:17 AM

Change 355041 merged by Hashar:
[mediawiki/extensions/Whoops@master] Switch .gitreview from defaultbranch to track

https://gerrit.wikimedia.org/r/355041

• demon added a comment.May 22 2017, 4:03 PM

If we update docs to tell people to use ~/.config/git-review/git-review.conf, we can specify most of the values (host, port, track, defaultrebase) there, then .gitreview files would only need the project listed. Default behaviors would be nicer :)

• Mholloway subscribed.Jul 25 2017, 1:51 PM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:47 PM
• demon mentioned this in rESRD739a0e0244f6: Swapping defaultbranch for trace.Jul 27 2019, 11:17 PM
• demon mentioned this in rEEUSfee6453ede35: Swapping defaultbranch for trace.May 25 2023, 5:57 PM
• demon mentioned this in rEOAL876090e5fe4d: Swapping defaultbranch for trace.May 25 2023, 6:04 PM
• demon mentioned this in rEPRZ4c1a4dcfbb3d: Swapping defaultbranch for trace.May 25 2023, 6:53 PM
• demon mentioned this in rENBVceb53cf52ecf: Swapping defaultbranch for trace.
• demon mentioned this in rENBU24b67471183b: Swapping defaultbranch for trace.
• demon mentioned this in rEMMH3c4e9c633122: Swapping defaultbranch for trace.May 25 2023, 6:56 PM
• demon mentioned this in rELNTd92764fc8d6a: Swapping defaultbranch for trace.
• demon mentioned this in rEMNLe9fd69b47398: Swapping defaultbranch for trace.
• demon mentioned this in rEMME8f4cb4589fce: Swapping defaultbranch for trace.May 25 2023, 6:58 PM
• demon mentioned this in rELTGf46d2d899700: Swapping defaultbranch for trace.May 25 2023, 7:05 PM
• demon mentioned this in rEQSL4ae80ea7a879: Swapping defaultbranch for trace.May 25 2023, 7:12 PM
gerritbot added a comment.Sep 11 2023, 1:06 PM

Change 955022 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/FileExporter@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955022

gerritbot added a comment.Sep 11 2023, 1:07 PM

Change 955023 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/FileImporter@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955023

gerritbot added a comment.Sep 11 2023, 1:07 PM

Change 956010 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/WikibaseStatementUpdater@master] .gitreview: Remove defaultbranch

https://gerrit.wikimedia.org/r/956010

gerritbot added a comment.Sep 11 2023, 1:07 PM

Change 955025 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/SecurityApi@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955025

gerritbot added a comment.Sep 11 2023, 1:07 PM

Change 956008 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[data-values/value-view@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/956008

gerritbot added a comment.Sep 11 2023, 1:07 PM

Change 955019 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/ArticleCreationWorkflow@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955019

gerritbot added a comment.Sep 15 2023, 4:34 PM

Change 956008 merged by jenkins-bot:

[data-values/value-view@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/956008

gerritbot added a comment.Sep 15 2023, 4:55 PM

Change 955022 merged by jenkins-bot:

[mediawiki/extensions/FileExporter@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955022

gerritbot added a comment.Sep 15 2023, 4:55 PM

Change 955025 merged by jenkins-bot:

[mediawiki/extensions/SecurityApi@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955025

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 15 2023, 5:00 PM
thiemowmde mentioned this in rESAP1fd43c6376b1: .gitreview: Swap to track=1.Sep 15 2023, 5:08 PM
thiemowmde mentioned this in rEFILEEXPORT85de77235504: .gitreview: Swap to track=1.Sep 15 2023, 5:12 PM
gerritbot added a comment.Sep 16 2023, 12:24 AM

Change 955023 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955023

gerritbot added a comment.Sep 22 2023, 1:42 PM

Change 955019 merged by jenkins-bot:

[mediawiki/extensions/ArticleCreationWorkflow@master] .gitreview: Swap to track=1

https://gerrit.wikimedia.org/r/955019

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 22 2023, 2:00 PM
gerritbot added a comment.Oct 20 2023, 12:33 PM

Change 967440 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/[email protected]] Remove `defaultbranch=master` from .gitreview

https://gerrit.wikimedia.org/r/967440

gerritbot added a comment.Oct 25 2023, 11:05 AM

Change 967440 merged by jenkins-bot:

[operations/software/[email protected]] Remove `defaultbranch=master` from .gitreview

https://gerrit.wikimedia.org/r/967440

gerritbot added a comment.Dec 15 2023, 1:48 PM

Change 983408 had a related patch set uploaded (by Hashar; author: Hashar):

[wikimedia/portals@master] Remove `defaultbranch=master` from .gitreview

https://gerrit.wikimedia.org/r/983408

gerritbot added a comment.Dec 15 2023, 2:30 PM

Change 983408 merged by jenkins-bot:

[wikimedia/portals@master] Remove `defaultbranch=master` from .gitreview

https://gerrit.wikimedia.org/r/983408

gerritbot added a comment.Oct 30 2024, 8:31 AM

Change #956010 merged by jenkins-bot:

[mediawiki/extensions/WikibaseStatementUpdater@master] .gitreview: Remove defaultbranch

https://gerrit.wikimedia.org/r/956010

thiemowmde mentioned this in rEWSU6221112a301a: .gitreview: Remove defaultbranch.Oct 30 2024, 8:31 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 30 2024, 9:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits