Page MenuHomePhabricator
Create Task
Maniphest T145519

Pin button appears too big is out of place
Closed, ResolvedPublic
Actions

Description

I am finding that the pin button is often not quite in the right place resulting in the appearance seen below.

pasted_file (55×101 px, 757 B)

I imagine this is not desired and should be fixed.

Details

SubjectRepoBranchLines +/-
Add margin to pin buttonmediawiki/extensions/RevisionSlidermaster+6 -2
Fix pin button stylemediawiki/extensions/RevisionSlidermaster+12 -10
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Sep 13 2016, 2:53 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 13 2016, 2:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from Incoming to Doing on the Revision-Slider board.Sep 15 2016, 9:32 AM
gerritbot subscribed.Sep 15 2016, 9:34 AM

Change 310766 had a related patch set uploaded (by Addshore):
Fix pin button style

https://gerrit.wikimedia.org/r/310766

gerritbot added a project: Patch-For-Review.Sep 15 2016, 9:34 AM
Addshore mentioned this in rERSL0e702f9a416e: Fix pin button style.Sep 15 2016, 9:35 AM
Addshore moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Sep 19 2016, 8:33 AM
Tobi_WMDE_SW mentioned this in rERSL5c9b9f7eb4f1: Fix pin button style.Sep 20 2016, 10:41 AM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Team-Experimental-Sprint.Sep 22 2016, 10:43 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the WMDE-QWERTY-Team-Experimental-Sprint board.
gerritbot added a comment.Sep 26 2016, 8:20 AM

Change 310766 merged by jenkins-bot:
Fix pin button style

https://gerrit.wikimedia.org/r/310766

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 26 2016, 9:00 AM
Tobi_WMDE_SW moved this task from Review to Done on the WMDE-QWERTY-Team-Experimental-Sprint board.Sep 27 2016, 10:14 AM
Tobi_WMDE_SW moved this task from Doing to Done on the Revision-Slider board.
Tobi_WMDE_SW closed this task as Resolved.Sep 27 2016, 3:15 PM
Tobi_WMDE_SW claimed this task.
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team-Experimental-Sprint board.Oct 25 2016, 12:21 PM
gerritbot added a comment.Oct 28 2016, 2:03 PM

Change 318543 had a related patch set uploaded (by Tobias Gritschacher):
Add margin to pin button

https://gerrit.wikimedia.org/r/318543

Tobi_WMDE_SW mentioned this in rERSL995d95a52eb7: Add margin to pin button.Oct 28 2016, 2:07 PM
Tobi_WMDE_SW mentioned this in rERSL1bef0504296a: Add margin to pin button.Nov 2 2016, 1:19 PM
gerritbot added a comment.Nov 3 2016, 10:46 AM

Change 318543 merged by jenkins-bot:
Add margin to pin button

https://gerrit.wikimedia.org/r/318543

Addshore added a project: WMDE-TechWish.Nov 3 2016, 10:46 AM
Addshore moved this task from Proposed to Done on the WMDE-TechWish board.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 3 2016, 11:00 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Nov 8 2016, 3:11 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:02 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits