Page MenuHomePhabricator
Create Task
Maniphest T145243

Insert > Gallery should pre-load the article title in the search for images, like Insert > Media does
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

What happens now:

  1. Insert > Gallery
  2. Nothing.

What should happen:

  1. Insert > Gallery
  2. Search results, just like Insert > Media!

Details

SubjectRepoBranchLines +/-
Pre-load the article title in gallery dialog searchmediawiki/extensions/VisualEditormaster+14 -2
Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Sep 9 2016, 8:23 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 9 2016, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders added a subscriber: Tchanders.Sep 9 2016, 10:05 PM
Esanders subscribed.

I see this when I open the gallery dialog:

pasted_file (268×731 px, 14 KB)

Or do you mean we should autocomplete with the page title?

Jdforrester-WMF renamed this task from Insert > Gallery should search for images, just like Insert > Media does to Insert > Gallery should pre-load the article title in the search for images, like Insert > Media does.Sep 13 2016, 7:16 PM
Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
gerritbot subscribed.Sep 27 2016, 8:54 PM

Change 313118 had a related patch set uploaded (by Tchanders):
Pre-load the article title in gallery dialog search

https://gerrit.wikimedia.org/r/313118

gerritbot added a project: Patch-For-Review.Sep 27 2016, 8:54 PM
Tchanders added a comment.Sep 28 2016, 3:43 AM

Although I've put a patch up for review, I'm not sure I completely agree with doing this. It might look a bit slicker to have some images already loaded, but I would guess that it would only be useful in a very small percentage of cases.

• Whatamidoing-WMF added a comment.Sep 28 2016, 4:03 AM

(In reply to Ed's question) Yes, I mean that we should autocomplete the search with the page title, both when inserting a new gallery and also after clicking on "Add new image" to an existing one.

Tchanders added a comment.Sep 28 2016, 4:21 AM

Ok, that's what the patch in review does.

gerritbot added a comment.Oct 4 2016, 4:24 PM

Change 313118 merged by jenkins-bot:
Pre-load the article title in gallery dialog search

https://gerrit.wikimedia.org/r/313118

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Oct 4 2016, 5:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 4 2016, 5:20 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Ryasmeen added a project: Verified.Oct 4 2016, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits