Spotted 17 times in production, apparently new in wmf.17 branch:
Warning: Invalid argument: Type C: not enough input, need 1, have 0 in /srv/mediawiki/php-1.28.0-wmf.17/extensions/TimedMediaHandler/handlers/OggHandler/File_Ogg/File/Ogg.php on line 384
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add check to File_Ogg for cut-off page headers | mediawiki/extensions/TimedMediaHandler | master | +9 -0 |
@Dereckson hi is this still a problem, since there have been updates to tmh since then including updates to ogv.js?
This is a question to ask to TMH developers.
Last occurences in logs are 2016-09-17 (php-1.28.0-wmf.18) and 2016-09-23 (php-1.28.0-wmf.20).
php-1.28.0-wmf.20 is the version currently on Wikipedia and Commons.
Backend File_Ogg shouldn't have changed at all, this may be due to accesses to a particular file. Any info such as URL for the request?
Change 316000 had a related patch set uploaded (by Brion VIBBER):
Add check to File_Ogg for cut-off page headers
@Dereckson patch https://gerrit.wikimedia.org/r/316000 should do the job; checks that the Ogg page header is at least the expected length and will error out if not... in the error case the caller function throws an exception.
That exception should then either get caught by MediaWiki code and the file rejected, or will throw directly and be more visible in logs with request info etc.