| WMDE-leszek | |
| Aug 30 2016, 12:57 PM |
| F4489420: pasted_file | |
| Sep 20 2016, 8:35 AM |
| F4485999: pasted_file | |
| Sep 19 2016, 1:25 PM |
| F4485996: pasted_file | |
| Sep 19 2016, 1:25 PM |
It looks like when there is a long word/URL in an edit summary and it does not fit the popup, sometimes the scrollbar is missing.
E.g. on https://de.wikipedia.org/w/index.php?diff=121648836&oldid=99344045&title=Wikipedia%3AHauptseite&type=revision when hovering the newer revision, there is a scrollbar but when you scroll forward with an arrow, and hover this revision again, there is no scrollbar and contents of the popup are "clipped".
It looks like the OO.ui.PopupWidget is adding the overflow-x:scroll style to the incorrect div tag.
This style should be on the div with the "oo-ui-popupWidget-popup" class but instead is on the div with these classes "oo-ui-clippableElement-clippable oo-ui-popupWidget-body oo-ui-popupWidget-body-padded"
On a normal tooltip with a long summary this looks like:
When it should look like:
This isn't actually the issue described in the ticket, but fixing this will likely help.
Change 311638 had a related patch set uploaded (by Esanders):
Use word-break to avoid horizontal scrollbars inside popups
Change 311638 merged by jenkins-bot:
Use word-break to avoid horizontal scrollbars inside popups
Thanks @Esanders for the patch! It is a great improvement.
One more thing we could try to tweak is shown below, when a vertical scrollbar is shown it will cover parts of long strings in the popup.
Either vertical scrollbars could be switched off or some padding / shifting of text would be needed.
Change 313203 had a related patch set uploaded (by Tobias Gritschacher):
Add fixed padding for scrollbar