Page MenuHomePhabricator
Create Task
Maniphest T143650

Duplicate set of empty parameters can get added when editing some Infobox Film templates on de.wiki
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

At the German Wikipedia, some infobox film templates, if edited with VE, would result in a duplicate, empty set of parameters being added; to see this, try and VEdit the infobox at https://de.wikipedia.org/wiki/Alles_was_kommt. Others though don't seem to show this issue, https://de.wikipedia.org/wiki/Die_5._Welle for instance. I /think/ I have narrowed the problem down to "this happens when aliases are used for the template parameters", but those all seem to be valid aliases per https://de.wikipedia.org/wiki/Vorlage:Infobox_Film/Doku .

Details

SubjectRepoBranchLines +/-
Don't try to add suggested/required parameters already set under alias namesmediawiki/extensions/VisualEditormaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Aug 23 2016, 10:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2016, 10:49 AM
Jdforrester-WMF triaged this task as Medium priority.Aug 23 2016, 7:17 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• AlexMonk-WMF mentioned this in T146060: TemplateData parameters should not be case sensitive.Sep 29 2016, 9:55 PM
• AlexMonk-WMF subscribed.Sep 30 2016, 12:57 AM

I think this is because https://gerrit.wikimedia.org/r/#/c/288650/ doesn't take into account suggested/required parameters that are already set under one of their alias names instead of their normal key

gerritbot subscribed.Sep 30 2016, 12:58 AM

Change 313545 had a related patch set uploaded (by Alex Monk):
Don't try to add suggested/required parameters already set under alias names

https://gerrit.wikimedia.org/r/313545

gerritbot added a project: Patch-For-Review.Sep 30 2016, 12:58 AM
• AlexMonk-WMF claimed this task.Sep 30 2016, 12:58 AM
Zache subscribed.Sep 30 2016, 7:25 AM

I made test page for this and it looks like that Alex Monk is correct.

gerritbot added a comment.Oct 4 2016, 3:49 PM

Change 313545 merged by jenkins-bot:
Don't try to add suggested/required parameters already set under alias names

https://gerrit.wikimedia.org/r/313545

Jdforrester-WMF closed this task as Resolved.Oct 4 2016, 3:53 PM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)); removed Patch-For-Review.
• Whatamidoing-WMF awarded a token.Oct 14 2016, 5:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits