Page MenuHomePhabricator
Create Task
Maniphest T142912

HTMLFormFieldClone::getInputHTMLForKey is invoked with false $values parameter, array expected
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Invalid operand type was used: array_key_exists expects an array or an object; false returned.
in /srv/mediawiki/php-1.28.0-wmf.14/includes/htmlform/fields/HTMLFormFieldCloner.php on line 274

https://github.com/wikimedia/mediawiki/blame/wmf/1.28.0-wmf.14/includes/htmlform/fields/HTMLFormFieldCloner.php#L274

Method HTMLFormFieldClone::getInputHTMLForKey expect $values to be an array, not false value.

See also ed12473b15.

Details

SubjectRepoBranchLines +/-
Type hint array for HTMLFormFieldCloner::getInputHTMLForKey()mediawiki/coremaster+1 -1
HTMLFormFieldCloner: Pass enpty array, not null, to avoid warningmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Dereckson created this task.Aug 13 2016, 7:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2016, 7:03 PM
Dereckson updated the task description. (Show Details)Aug 13 2016, 7:03 PM
Dereckson updated the task description. (Show Details)
Dereckson added a subscriber: Anomie.
Dereckson added a project: MediaWiki-HTMLForm.Aug 13 2016, 7:06 PM
Tgr added a comment.Aug 13 2016, 10:35 PM

Per the phpdoc $values must be an array, so the error is somewhere further down the call stack.

Dereckson added a comment.Aug 14 2016, 2:31 AM

We don't currently have a stack trace.

Tgr added a comment.Aug 14 2016, 5:34 AM

Where does the error come from? I can't find it in logstash.

Anomie added a comment.Aug 15 2016, 2:15 PM

One likely case is https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/htmlform/fields/HTMLFormFieldCloner.php;06384c97f3d3fff2ca8615e4a53152845fcda810$357. The change from isset to array_key_exists in ed12473b would have had the side effect of causing this warning.

gerritbot subscribed.Aug 15 2016, 2:16 PM

Change 304820 had a related patch set uploaded (by Anomie):
HTMLFormFieldCloner: Pass enpty array, not null, to avoid warning

https://gerrit.wikimedia.org/r/304820

gerritbot added a project: Patch-For-Review.Aug 15 2016, 2:16 PM
gerritbot added a comment.Aug 15 2016, 2:35 PM

Change 304820 merged by jenkins-bot:
HTMLFormFieldCloner: Pass enpty array, not null, to avoid warning

https://gerrit.wikimedia.org/r/304820

gerritbot added a comment.Aug 15 2016, 2:41 PM

Change 304829 had a related patch set uploaded (by Florianschmidtwelzow):
Type hint array for HTMLFormFieldCloner::getInputHTMLForKey()

https://gerrit.wikimedia.org/r/304829

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes.Aug 15 2016, 3:00 PM
matmarex closed this task as Resolved.Aug 18 2016, 7:43 PM
matmarex assigned this task to Anomie.
matmarex removed a project: Patch-For-Review.
matmarex subscribed.

Looks fixed, no recent hits in logstash.

gerritbot added a comment.Aug 18 2016, 8:40 PM

Change 304829 merged by jenkins-bot:
Type hint array for HTMLFormFieldCloner::getInputHTMLForKey()

https://gerrit.wikimedia.org/r/304829

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 9:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits