Page MenuHomePhabricator
Create Task
Maniphest T141259

DuplicateReferences fails when the statement is in edit mode
Closed, ResolvedPublic
Actions

Description

When the insert reference link added by Gadget-DuplicateReferences.js is clicked on a statement that is in edit mode, it fails with an error as shown in the screenshot below.

w4.png (690×1 px, 53 KB)

Event Timeline

dachary created this task.Jul 25 2016, 12:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2016, 12:59 PM
dachary added a comment.Jul 25 2016, 12:59 PM

I propose the following patch to Gadget-DuplicateReferences.js to handle statements in edit mode differently. If the statement is in edit mode (i.e. the wb-edit class is present), the reference is added but not saved and the statement remains in edit mode.

a.patch2 KBDownload

dachary moved this task from Backlog to Bugs on the Wikidata-Gadgets board.Jul 26 2016, 6:20 AM
Sjoerddebruin subscribed.Sep 21 2016, 8:32 PM

This seems to be working now, at least for existing statements?

Lydia_Pintscher closed this task as Resolved.Oct 10 2016, 9:43 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher subscribed.

Setting to resolved based on @Sjoerddebruin's comment.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits