commonPrint.css: Proof and fix overqualified selectors and use of `!important` (CSSLint)
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Volker_E
	May 28 2016, 12:34 AM

Description

Follow-up on T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup:
Proof and fix overqualified selectors and use of !important in current commonPrint.css where applicable.

Currently CSSLint returns 60 warnings:

16 overqualified selectors
16 usage of !important
16 usage of ID in selectors

Details

	Subject	Repo	Branch	Lines +/-
	commonPrint: Remove overqualified selectors & `!important` where applicable	mediawiki/core	master	+8 -13

Customize query in gerrit

Related Objects

Mentioned In: T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup
Mentioned Here: T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup

Event Timeline

Volker_E created this task.May 28 2016, 12:34 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 28 2016, 12:34 AM

Volker_E mentioned this in T120154: Align commonPrint.css to (most) CSSLint errors&warnings and WMF's CSS Coding guidelines and cleanup.May 28 2016, 12:35 AM

Volker_E updated the task description. (Show Details)May 28 2016, 12:38 AM

Danny_B added a parent task: T14788: [DO NOT USE] CSS (tracking) [superseded by #CSS].May 28 2016, 1:45 AM

• Phabricator_maintenance added a project: CSS.Jul 29 2016, 7:15 PM

• Phabricator_maintenance removed a parent task: T14788: [DO NOT USE] CSS (tracking) [superseded by #CSS].Jul 29 2016, 7:16 PM

Change 313363 had a related patch set uploaded (by VolkerE):
commonPrint: Remove overqualified selectors & !important where applicable

https://gerrit.wikimedia.org/r/313363

gerritbot added a project: Patch-For-Review.Sep 29 2016, 7:04 AM

Hmmm, I'm not sure it's worth potential new bugs to address these linting warnings, particularly in a "legacy" stylesheet.

Change 313363 merged by jenkins-bot:
commonPrint: Remove overqualified selectors & !important where applicable

https://gerrit.wikimedia.org/r/313363

Volker_E removed a project: Patch-For-Review.Oct 14 2016, 7:58 PM

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 14 2016, 8:00 PM

With above patch we came down from 16 to 8 overqualified selectors. Gonna put this on declined fwiw. We can always re-open if we gonna feel need for more work here.

commonPrint.css: Proof and fix overqualified selectors and use of `!important` (CSSLint)Closed, DeclinedPublicActions

Description

Details

Related Objects

Event Timeline

commonPrint.css: Proof and fix overqualified selectors and use of `!important` (CSSLint)
Closed, DeclinedPublic
Actions