Page MenuHomePhabricator
Create Task
Maniphest T122347

Resizing a graph in VisualEditing mode will transform the JSON from block to inline
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I have inserted a graph in VisualEditing mode. Saved the page. Reopened the page in VisualEditing. Resized the graph using the arrows in the lowerright corner. Saved the paged. Checked the source and found the JSON specification has been collapsed from block to inline formatting.

Details

SubjectRepoBranchLines +/-
Display graphs as inline-blocks at first creation Fix popup widget displaying as anchored after resizing a graphmediawiki/extensions/Graphmaster+4 -0
Customize query in gerrit

Event Timeline

AdHuikeshoven created this task.Dec 23 2015, 9:06 PM
AdHuikeshoven raised the priority of this task from to Needs Triage.
AdHuikeshoven updated the task description. (Show Details)
AdHuikeshoven added a project: VisualEditor.
AdHuikeshoven added subscribers: Aklapper, AdHuikeshoven, StudiesWorld.
Jdforrester-WMF triaged this task as Low priority.Jan 19 2016, 8:06 PM
Jdforrester-WMF added projects: MediaWiki-extensions-Graph, VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF subscribed.

Isn't this intended? The JSON shouldn't be stored inline, I thought?

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jan 19 2016, 8:06 PM
Yurik moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.Feb 22 2016, 5:03 AM
• ferdbold claimed this task.Sep 25 2016, 6:29 PM
• ferdbold added a comment.Sep 25 2016, 7:39 PM

This is due to the graph extension stylesheet not being loaded the first time a graph is created on a page, resulting in VE wrongly displaying them as blocks. According to the stylesheet graphs should always be displayed as an inline-block.

gerritbot subscribed.Sep 25 2016, 9:42 PM

Change 312794 had a related patch set uploaded (by Ferdbold):
Display graphs as inline-blocks at first creation Fix popup widget displaying as anchored after resizing a graph

https://gerrit.wikimedia.org/r/312794

gerritbot added a project: Patch-For-Review.Sep 25 2016, 9:42 PM
gerritbot added a comment.Sep 26 2016, 12:02 AM

Change 312794 merged by jenkins-bot:
Display graphs as inline-blocks at first creation Fix popup widget displaying as anchored after resizing a graph

https://gerrit.wikimedia.org/r/312794

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 26 2016, 1:00 AM
Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.Oct 3 2016, 8:03 PM
Jdforrester-WMF moved this task from Blocked to External and Administrivia on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Oct 3 2016, 8:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits