Page MenuHomePhabricator
Create Task
Maniphest T117545

In the cross-wiki upload tool, the upload can timeout causing an unhandled exception
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

When trying to upload a large file, after about 30s and exception is thrown, and dialog gets stuck in a pending state. In Upload.BookletLayout, the uploadPromise fails onto line 201, where it calls getErrorMessageForStateDetails. On line 262 stateDetails.error is undefined, so an exception is thrown on 268.

Details

SubjectRepoBranchLines +/-
mw.api.upload: Suppress default API call timeoutmediawiki/coremaster+2 -0
Don't default to 30s timeout for file uploadsmediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Nov 3 2015, 2:29 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: Multimedia, VisualEditor, VisualEditor-MediaWiki-Media.
Esanders subscribed.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptNov 3 2015, 2:29 PM
Esanders added a comment.Nov 3 2015, 2:32 PM

There probably shouldn't be a timeout at all - it would help if we had a progress bar though.

Jdforrester-WMF renamed this task from Upload can timeout causing an unhandled exception to In the cross-wiki upload system, the upload can timeout causing an unhandled exception.Nov 3 2015, 8:06 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF moved this task from Untriaged to Next up on the Multimedia board.Nov 5 2015, 4:07 PM
Jdforrester-WMF renamed this task from In the cross-wiki upload system, the upload can timeout causing an unhandled exception to In the cross-wiki upload tool, the upload can timeout causing an unhandled exception.Nov 5 2015, 6:29 PM
gerritbot subscribed.Sep 21 2016, 3:05 PM

Change 312010 had a related patch set uploaded (by Matthias Mullie):
Don't default to 30s timeout for file uploads

https://gerrit.wikimedia.org/r/312010

gerritbot added a project: Patch-For-Review.Sep 21 2016, 3:05 PM
matthiasmullie claimed this task.Sep 21 2016, 3:06 PM
matthiasmullie moved this task from Next up to Needs code review on the Multimedia board.
matmarex added a project: MediaWiki-Uploading.Sep 21 2016, 5:20 PM
matmarex merged a task: T141814: Getting error while uploading image with the upload dialog (timeout).
matmarex added subscribers: Tanveer07, matmarex, greg, Ryasmeen.
gerritbot added a comment.Sep 21 2016, 5:21 PM

Change 310595 had a related patch set uploaded (by Bartosz Dziewoński):
mw.api.upload: Suppress default API call timeout

https://gerrit.wikimedia.org/r/310595

matmarex added a comment.Sep 21 2016, 5:22 PM

Per T141814, this is not causing exceptions today, but a nasty error message appears (and of course the upload doesn't succeed). Please file bugs related to the upload dialog in MediaWiki-Uploading (it is used by more than just VisualEditor).

gerritbot added a comment.Sep 21 2016, 6:28 PM

Change 312010 abandoned by MarkTraceur:
Don't default to 30s timeout for file uploads

Reason:
Superseded by 310595, merged just now

https://gerrit.wikimedia.org/r/312010

gerritbot added a comment.Sep 21 2016, 6:48 PM

Change 310595 merged by MarkTraceur:
mw.api.upload: Suppress default API call timeout

https://gerrit.wikimedia.org/r/310595

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release-notes.Sep 21 2016, 7:00 PM
matmarex closed this task as Resolved.Sep 21 2016, 7:02 PM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits