Page MenuHomePhabricator
Create Task
Maniphest T117083

Link education pop-up appears at the start of every editing session, not just once per user
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

From {T108620#1765749}

Steps to reproduce:

  1. Go to a wiki with these prompts enabled (this has been reproduced so far on meta, enwiki, officewiki, and enwikivoyage).
  2. Open a page. Click in the toolbar to make a link. Read and close the educational pop-up.
  3. Save the page.
  4. Refresh the page (maybe not necessary?)
  5. Open it again.
  6. See the blue dot on the link item in the toolbar again.

Details

SubjectRepoBranchLines +/-
Register the preference to hide education popupsmediawiki/extensions/VisualEditorwmf/1.27.0-wmf.4+1 -0
Register the preference to hide education popupsmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Oct 29 2015, 7:34 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2015, 7:34 PM
• Whatamidoing-WMF assigned this task to Krenair.Oct 29 2015, 7:35 PM
• Whatamidoing-WMF added projects: VisualEditor, VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki.
• Whatamidoing-WMF set Security to None.
• Whatamidoing-WMF mentioned this in T108620: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them.
Ryasmeen subscribed.Oct 29 2015, 10:09 PM

This happened on Beta for me as well, thought this is a Beta specific issue. Seems like its not.

For me, the blue-dot re-appears after an idle time on the same session.

Ryasmeen added a comment.Oct 30 2015, 1:50 AM

Also, was able to reproduce in en.wiki just now

gerritbot subscribed.Oct 30 2015, 2:13 AM

Change 249949 had a related patch set uploaded (by Alex Monk):
Register the preference to hide education popups

https://gerrit.wikimedia.org/r/249949

gerritbot added a project: Patch-For-Review.Oct 30 2015, 2:13 AM
• Elitre subscribed.Oct 30 2015, 10:21 AM

Yeah, I'm also seeing them on en.wp now.
Another thing, since I'm here: when I close the pop-up, I don't really expect having to click again on the button to use the link/cite tool.

gerritbot added a comment.Oct 30 2015, 11:51 AM

Change 249949 merged by jenkins-bot:
Register the preference to hide education popups

https://gerrit.wikimedia.org/r/249949

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 30 2015, 12:00 PM
• Elitre added a comment.Oct 30 2015, 1:14 PM

(Yet another thing... on Office wiki I think I see the link popup but not the blue dot?)

gerritbot added a comment.Oct 30 2015, 1:21 PM

Change 249998 had a related patch set uploaded (by Alex Monk):
Register the preference to hide education popups

https://gerrit.wikimedia.org/r/249998

gerritbot added a comment.Oct 30 2015, 1:26 PM

Change 249998 merged by jenkins-bot:
Register the preference to hide education popups

https://gerrit.wikimedia.org/r/249998

Krenair added a comment.Oct 30 2015, 1:50 PM

Commit is deployed, seems to have fixed the issue. Not closing this because I'm planning to investigate @Elitre's officewiki issue when I get back later.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 30 2015, 2:00 PM
Krenair added a comment.Oct 30 2015, 8:54 PM

@Elitre: Can you still reproduce that issue? I saw the blue dot...

Jdforrester-WMF closed this task as Resolved.Oct 31 2015, 12:08 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
nshahquinn-wmf renamed this task from Link education pop-up appears at the start of every editing session, not just once per user, at Meta to Link education pop-up appears at the start of every editing session, not just once per user.Oct 31 2015, 11:17 PM
nshahquinn-wmf reopened this task as Open.
nshahquinn-wmf updated the task description. (Show Details)
nshahquinn-wmf subscribed.

I just saw this on English Wikipedia. Doesn't seem to be resolved.

nshahquinn-wmf closed this task as Resolved.Oct 31 2015, 11:24 PM

Actually, that might just have been my first time seeing it on enwiki. It's likely fixed after all.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits