Page MenuHomePhabricator
Create Task
Maniphest T116588

mw.TitleSearchWidget: For transparent images, set the background colour to white so it isn't on grey
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Search e.g. for Wikidata on the English Wikipedia; the GIF is mastered off white, but the background inheritance is set to grey for some reason. Setting background-color: white fixes it.

Details

SubjectRepoBranchLines +/-
TitleOptionWidget: Only set grey bg for iconsmediawiki/coremaster+15 -14
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Oct 26 2015, 2:26 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, MediaWiki-General.
Jdforrester-WMF added subscribers: Jdforrester-WMF, matmarex, Esanders.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2015, 2:26 PM
gerritbot subscribed.Oct 26 2015, 2:58 PM

Change 248879 had a related patch set uploaded (by Esanders):
TitleOptionWidget: Only set grey bg for icons

https://gerrit.wikimedia.org/r/248879

gerritbot added a project: Patch-For-Review.Oct 26 2015, 2:58 PM
Esanders added a comment.Oct 26 2015, 3:02 PM
pasted_file (483×411 px, 46 KB)
pasted_file (489×412 px, 46 KB)
Jdforrester-WMF closed this task as Resolved.Oct 26 2015, 3:32 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Oct 26 2015, 3:42 PM

Change 248879 merged by jenkins-bot:
TitleOptionWidget: Only set grey bg for icons

https://gerrit.wikimedia.org/r/248879

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), MW-1.27-release-notes.Oct 26 2015, 4:00 PM
Jdforrester-WMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Oct 31 2015, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits