Wrong AF variables computed for MassMessage account for edits on Flow topics
Closed, ResolvedPublic
Actions

Description

Expected: user_name - MediaWiki message delivery user_editcount - whatever is the actual editcount

	Subject	Repo	Branch	Lines +/-
	AbuseFilter: Get user from context instead of at initialization	mediawiki/extensions/Flow	master	+14 -14

Mentioned In: T116211: Improve/investigate solutions for the Flow botspam
T115128: AbuseFilter test tools does not work for Flow edits
Mentioned Here: T115128: AbuseFilter test tools does not work for Flow edits

Glaisher raised the priority of this task from to Needs Triage.

Glaisher updated the task description. (Show Details)

Glaisher subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Legoktm triaged this task as High priority.Oct 19 2015, 4:55 PM

Legoktm subscribed.

Flow reads and stores the value of $wgUser during $wgExtensionFunctions in FlowHooks::getAbuseFilter(), which is way too early.

Change 247301 had a related patch set uploaded (by Legoktm):
AbuseFilter: Get user from context instead of at initialization

Legoktm set Security to None.

Change 247301 merged by jenkins-bot:
AbuseFilter: Get user from context instead of at initialization

Legoktm closed this task as Resolved.Oct 23 2015, 5:59 PM

Looks like this is still not fixed...

It's actually fixed. https://www.mediawiki.org/wiki/Special:AbuseFilter/examine/2140225 I guess I updated the filter before this reached mediawiki.org causing it to be blocked again.