"Remove" button for individual files in the upload step should be a OOjs UI button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Sep 30 2015, 9:45 AM

Description

"Remove" button for individual files in the upload step should be a OOjs UI button.

	Subject	Repo	Branch	Lines +/-
	Replace jquery.removeCtrl with an OO.ui.ButtonWidget	mediawiki/extensions/UploadWizard	master	+31 -62

matmarex raised the priority of this task from to Low.

matmarex updated the task description. (Show Details)

Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript

Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 30 2015, 5:32 PM

TasneemLo set Security to None.

AbdealiJK removed TasneemLo as the assignee of this task.Oct 7 2015, 1:34 PM

Change 244668 had a related patch set uploaded (by Prtksxna):
Replce jquery.removeCtrl with an OO.ui.ButtonWidget

Screenshots of proposed patch:

Looks like line height issues. Also you might want to use a frameless button

@Esanders, frameless does look better

matmarex closed this task as Resolved.Oct 27 2015, 3:00 PM

Change 244668 merged by jenkins-bot:
Replace jquery.removeCtrl with an OO.ui.ButtonWidget

	F2839770: Screen Shot 2015-10-26 at 9.00.12 PM.png
	Oct 26 2015, 3:31 PM

	F2751461: pasted_file
	Oct 21 2015, 5:15 PM

	F2751468: pasted_file
	Oct 21 2015, 5:15 PM