Page MenuHomePhabricator
Create Task
Maniphest T109977

"Title::newFromTitle: $text must be a string" from Linker::formatLinksInComment
Closed, ResolvedPublic
Actions

Description

Warning: Title::newFromTitle: $text must be a string
from
../Linker::formatComment/Linker::formatLinksInComment/Closure$Linker::formatLinksInComment/Title::newFromText

Several different stacks hit this:

  • Linker::commentBlock/Linker::formatComment/Linker::formatLinksInComment/Closure$Linker::formatLinksInComment/Title::newFromText
  • MobileSpecialPageFeed::formatComment/Linker::formatComment/Linker::formatLinksInComment/Closure$Linker::formatLinksInComment/Title::newFromText
  • ImageListPager::formatValue/Linker::formatComment/Linker::formatLinksInComment/Closure$Linker::formatLinksInComment/Title::newFromText
  • ImageHistoryList::imageHistoryLine/Linker::formatComment/Linker::formatLinksInComment/Closure$Linker::formatLinksInComment/Title::newFromText

About 200 hits collectively from these per day in Logstash for channel T76305. Method Linker::formatComment supports null, but further down its assumed to exist.

Details

SubjectRepoBranchLines +/-
Avoid "$text must be a string" in Linker::formatLinksInCommentmediawiki/coremaster+12 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Aug 23 2015, 1:15 PM
Krinkle raised the priority of this task from to Medium.
Krinkle raised the priority of this task from Medium to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Wikimedia-production-error, MediaWiki-General.
Krinkle set Security to None.
Krinkle added subscribers: aude, Krenair, Aklapper, Reedy.
• demon triaged this task as Medium priority.Aug 24 2015, 3:19 AM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 24 2015, 3:20 AM
gerritbot subscribed.Oct 16 2015, 5:28 PM

Change 246860 had a related patch set uploaded (by Umherirrender):
Avoid "$text must be a string" in Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/246860

gerritbot added a project: Patch-For-Review.Oct 16 2015, 5:28 PM
gerritbot added a comment.Nov 3 2015, 3:33 PM

Change 246860 merged by jenkins-bot:
Avoid "$text must be a string" in Linker::formatLinksInComment

https://gerrit.wikimedia.org/r/246860

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 3 2015, 4:00 PM
Umherirrender closed this task as Resolved.Nov 3 2015, 6:30 PM
Umherirrender claimed this task.
• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Nov 3 2015, 10:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits