Page MenuHomePhabricator
Create Task
Maniphest T109583

[Bug] Rank selector stays in edit mode after finishing editing
Closed, ResolvedPublic
Actions

Description

When editing quantity or monolingual text values, rank selctor stays in edit mode after finishing editing.

Steps to reproduce:

  • Edit quantity or monolingual text
  • Click save

pasted_file (150×948 px, 12 KB)

Event Timeline

• Jonas created this task.Aug 19 2015, 1:38 PM
• Jonas raised the priority of this task from to Medium.
• Jonas updated the task description. (Show Details)
• Jonas added projects: Wikidata, ValueView, good first task, patch-welcome, Technical-Debt.
• Jonas subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 1:38 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Aug 20 2015, 9:35 AM
Bene renamed this task from [Bug] Rank selctor stays in edit mode after finishing editing to [Bug] Rank selector stays in edit mode after finishing editing.Aug 27 2015, 11:06 AM
Bene removed a project: good first task.
Bene set Security to None.
matej_suchanek added a project: TestMe.Apr 16 2016, 8:32 AM
matej_suchanek removed a project: TestMe.Apr 16 2016, 9:16 AM
matej_suchanek updated the task description. (Show Details)
matej_suchanek updated the task description. (Show Details)Apr 16 2016, 9:19 AM
matej_suchanek closed this task as Resolved.May 6 2016, 7:29 PM
matej_suchanek subscribed.

Cannot reproduce.

matej_suchanek reopened this task as Open.May 29 2016, 7:48 AM

Can reproduce again:
Initial statement:

bug1.png (325×949 px, 17 KB)

After saving:

bug2.png (207×931 px, 12 KB)

• Jonas added a comment.May 29 2016, 7:57 AM

I cannot reproduce.
Could you please provide steps to reproduce. Thanks.

matej_suchanek added a comment.EditedMay 29 2016, 7:59 AM
  1. Go to https://www.wikidata.org/wiki/Q22210265 and edit P18
  2. Click add qualifier and add P2096 from the reference
  3. Remove the reference
  4. Click save
• Jonas added a subscriber: Lydia_Pintscher.May 30 2016, 10:33 AM
Lydia_Pintscher added a comment.May 30 2016, 1:55 PM

I just tested it and it still happens. It doesn't even seem to need any complicateed edit - just any edit of a statement seems to do.

• Jonas closed this task as Resolved.Jun 16 2016, 11:11 AM
• Jonas added a project: Wikidata-Sprint-2016-05-24.
• Jonas moved this task from Proposed to Done on the Wikidata-Sprint-2016-05-24 board.
thiemowmde subscribed.Jun 23 2016, 3:14 PM

Was https://gerrit.wikimedia.org/r/294481 the patch that fixed this?

• Jonas added a comment.Jun 23 2016, 4:14 PM

Yes, I think so.

matej_suchanek unsubscribed.Mar 24 2017, 5:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits