Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error for long svg data uri #419

Closed
wei opened this issue Dec 12, 2024 · 7 comments · Fixed by #440
Closed

Display error for long svg data uri #419

wei opened this issue Dec 12, 2024 · 7 comments · Fixed by #440
Assignees
@spudoodle
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wei
Copy link
Owner

wei commented Dec 12, 2024 •
edited
Loading

When user enters a SVG data uri that is more than 1,600 characters,

  1. Add a warning or error (red border) around the SVG Logo input
  2. Display a message "URI is too long, please use an SVG image URL instead."

Originally posted by @wei in #406 (comment)
@wei wei added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2024
@spudoodle
Copy link
Contributor

Hey, I would like to work on this

@wei
Copy link
Owner Author

wei commented Dec 12, 2024

Hiiii @slusy, welcome!! Assigned 😄

@wei
Copy link
Owner Author

wei commented Dec 12, 2024

@slusy You can use input-error and bottom left label from: https://daisyui.com/components/input/
Be sure to update tests to include this new use-case. Thank you!

@spudoodle
Copy link
Contributor

@wei Sure, I will do it

@spudoodle
Copy link
Contributor

Hey @wei, when running the e2e tests it's generating new snapshots for Darwin. Should I include this as well in the PR?

@wei
Copy link
Owner Author

wei commented Dec 13, 2024

@slusy I see we'll need to figure out the best way to handle that since the screenshots are currently generated based on Linux chrome.

For now could you generate and commit in GitHub codespaces which is Ubuntu?

@spudoodle
Copy link
Contributor

Yeah, let me check it out

@spudoodle spudoodle mentioned this issue Dec 13, 2024
Merged
@wei wei closed this as completed in #440 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spudoodle spudoodle

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Better warning for long logo data uri spudoodle/socialify
2 participants
@wei @spudoodle