sse syntax update concept #311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkieltyka
commented
Sep 30, 2024
- AbortController will automatically be created if one is not passed in
- Stream call returns the abort function on the controller, and also a .wait in case someone wants to block until the connection is done..? maybe we think of another name, and perhaps this isn't very useful or we should modify this to a fan out thing, as I imagine if its called multiple times, it won't work very well..
- the primary reason for this change though is to simplify how developers need to think about the AbortController and instead return it as part of the API as the default option while preserving previous functionality / capability
VojtechVitek
reviewed
Oct 2, 2024
Comment on lines
77
to
81
| const stream = api.subscribeMessages( | ||
| { username }, | ||
| { onMessage, onError, onOpen, onClose }//, signal: controller } | ||
| ); |
There was a problem hiding this comment.
I like how the returned stream.abort() reads if you don't provide your own 👍
| const resp = _fetch(); | ||
| return { | ||
| abort: abortController.abort.bind(abortController), | ||
| wait: resp |
There was a problem hiding this comment.
since we have onClose(), perhaps we don't need this wait return argument
or is there a use-case for awaiting stream right away and blocking on the operation? is it idiomatic?
await stream.closed
this would have to raise exception, that you can normally get through onError()
@AlexanderKolberg thoughts?
pkieltyka
commented
Oct 2, 2024
| export interface WebrpcOptions { | ||
| headers?: HeadersInit; | ||
| signal?: AbortSignal; | ||
| controller?: AbortController; |
There was a problem hiding this comment.
I renamed from signal to controller here. Let me know if you guys think this is fine or if it breaks any functionality / uses from before?
pkieltyka
commented
Oct 2, 2024
4ca8d74 to
1be7c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.