Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vmware/govmomi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.1
Choose a base ref
...
head repository: vmware/govmomi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.26.2
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Mar 22, 2022

  1. fix: avoid use of vNIC IP in guest.TransferURL if there are multiple 

    InitiateFileTransfer{To,From}Guest methods return an ESX host's inventory name (HostSystem.Name).
This name was used to add the host to vCenter and cannot be changed
(unless the host is removed from inventory and added back with another name).
The name used when adding to VC may not resolvable by this client's DNS, so we prefer an ESX management IP.
However, if there is more than one management vNIC, we don't know which IP(s) the client has a route to.
Leave the hostname as-is in that case or if the env var has disabled the preference.
    dougm committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    566d2ac View commit details
    Browse the repository at this point in the history

  2. fix: avoid possible panic in HostSystem.ManagementIPs 

    If the HostSystem.Config or HostSystem.Config.VirtualNicManagerInfo fields are nil, the ManagementIPs method would panic.
I was not able to reproduce this situation in a real VC, even with disconnecting a host from VC.
Assuming this state is possible while an ESX host is being upgraded. Updated the test to nil both fields to ensure we don't panic.
    dougm committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    76a22af View commit details
    Browse the repository at this point in the history
Loading