-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate twisted.news #9405
Comments
Can you raise this on the mailing list first? Dropping a major component like this should have some visibility. If we do go ahead with this, we should delete its prominent mention from https://twistedmatrix.com/trac/wiki/SuccessStories#Mailman |
|
|
Here is the aforementioned (non-)discussion as a link: https://twistedmatrix.com/pipermail/twisted-python/2018-April/031882.html |
Reviewed over at #1144 (review). I'll go delete the relevant success story. |
Currently, t.news has below-Twisted standards of code coverage, implementation (with one huuuuge ad-hoc state machine), comments, tests, etc. It's also not had any changes to the bulk of its code for 14 years, apart from what appears to be code removal 6 years ago and a handful of "twisted-wide" mechanical syntax changes. It's also unlikely to ever be ported to Python 3 unless someone were to improve the former issues (since the port would require 100%-as-possible code coverage).
I propose deprecating twisted.news on the condition that it doesn't have a maintainer, and un-deprecating it if a user of the code steps up to maintain it and brings it into line (vs one of the current development team taking on work keeping an ancient protocol on life support). If nobody steps up, then we remove it at the end of the deprecation period and encourage any remaining users to either pin to old Twisteds or simply vendor the code in their own codebase.
Searchable metadata
The text was updated successfully, but these errors were encountered: