Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex filter #1845

Merged
merged 4 commits into from
Apr 16, 2017
Merged

fix regex filter #1845

merged 4 commits into from
Apr 16, 2017

Conversation

abcang
Copy link
Contributor

@abcang abcang commented Apr 15, 2017

Fixed a bug that regex filter matches HTML tag generated by simple_format.

  • completion of line breaks
  • tag deletion
  • unescape

@Gargron
Copy link
Member

Gargron commented Apr 15, 2017

Have you noticed if doing the DOM parsing in a loop makes the columns noticeably laggier?

@abcang
Copy link
Contributor Author

abcang commented Apr 15, 2017

I confirmed that it will be delayed.
I would like to think of another way.
Thank you.

@Gargron
Copy link
Member

Gargron commented Apr 15, 2017

@abcang Perhaps something like an extra reducer where you would store the indexable plaintext at time of entry, and then that would become part of the status object in the container and could be filtered-on.

Don't worry if this sounds too complicated, I might do it later...

@abcang
Copy link
Contributor Author

abcang commented Apr 16, 2017

Yes, I think so too.
And instead of deleting tags and escaping on the client side, I'd like to change the server side to send raw content.

@abcang
Copy link
Contributor Author

abcang commented Apr 16, 2017

I changed to send raw content on the server side.
But, in the case of remote toot, I noticed that escaped content was sent.
Therefore, I am planning to return to the process to escape on the client side.

@abcang
Copy link
Contributor Author

abcang commented Apr 16, 2017

I changed it to unescape in reducer.
Therefore, the lag problem was solved.

@Gargron Gargron merged commit 90760ea into mastodon:master Apr 16, 2017
@alpaca-tc alpaca-tc deleted the fix/regex_filter branch April 24, 2017 03:18
Apr 25, 2017
* fix regex filter

* fixed br to linebreak and, stlip tags.

* change to send raw content

* changed to unescape in reducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants