Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save gas by using a ParameterizerInterface in Registry #64

Open
adklempner opened this issue Apr 29, 2018 · 2 comments
Open

Save gas by using a ParameterizerInterface in Registry #64

adklempner opened this issue Apr 29, 2018 · 2 comments
Labels
enhancement good first issue

Comments

@adklempner
Copy link

Presently, Registry.sol imports Parameterizer.sol in its entirety, but only calls the function get(string _name).

You can save gas and storage space by using a ParameterizerInterface.sol in Registry

interface ParameterizerInterface {
        function get(string _name) public view returns (uint value);
}
@adklempner
Copy link
Author

I believe the same is true for PLCRVoting

@robrobbins
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robrobbins @skmgoldin @adklempner