replace sparkle with glow in components/script #33911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
jdm
approved these changes
Oct 19, 2024
wulanseruniati
pushed a commit
to wulanseruniati/servo
that referenced
this pull request
Oct 20, 2024
I think this will resolve problem observed in servo#33896 (comment) Signed-off-by: Samson <[email protected]> replace sparkle with glow in components/script (servo#33911) * replace sparkle's GlType with canvas_traits's GlType Signed-off-by: sagudev <[email protected]> * remove sparkle from components/servo Signed-off-by: sagudev <[email protected]> * remove sparkle from script Signed-off-by: sagudev <[email protected]> --------- Signed-off-by: sagudev <[email protected]> Replace CanGc::note() with arguments passed by callers Signed-off-by: Wulan Seruniati Salim <[email protected]> Addressed review feedback by removing comment resolve rebase conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by replacing sparkle::gl with glow.
Part of #33539
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors