CanGc fixes and checks in multiple files #33836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File Changes:
Replaced
CanGc::note()
calls in these files + made required entries in Bindings.confcomponents/script/webdriver_handlers.rs
components/script/dom/popstateevent.rs
components/script/dom/uievent.rs
components/script/dom/rtcpeerconnection.rs
-only the one in line 768 could be changed.Files that couldn't be changed:
components/script/dom/fontfaceset.rs
-leads to changes in macro_rules! in task.rscomponents/script/dom/securitypolicyviolationevent.rs
-leads to changes in macro_rules! in task.rscomponents/script/dom/errorevent.rs
-leads to changes in drop method ofDrop
trait implementationcomponents/script/dom/audiobuffer.rs
-leads to changes in macro_rules! in task.rscomponents/script/dom/bindings/settings_stack.rs
-leads to changes inDrop
trait implementationcomponents/script/dom/eventtarget.rs
-leads to changes in macro_rules! in task.rscomponents/script/dom/xrreferencespaceevent.rs
-leads to changes in macro_rules! in task.rscomponents/script/dom/hashchangeevent.rs
-leads to changes in macro_rules! in task.rs./mach build -d
does not report any errors./mach test-tidy
does not report any errors