Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanGc fixes and checks in multiple files #33836

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

chickenleaf
Copy link
Contributor

File Changes:
Replaced CanGc::note() calls in these files + made required entries in Bindings.conf

  1. components/script/webdriver_handlers.rs
  2. components/script/dom/popstateevent.rs
  3. components/script/dom/uievent.rs
  4. components/script/dom/rtcpeerconnection.rs -only the one in line 768 could be changed.

Files that couldn't be changed:

  1. components/script/dom/fontfaceset.rs -leads to changes in macro_rules! in task.rs
  2. components/script/dom/securitypolicyviolationevent.rs -leads to changes in macro_rules! in task.rs
  3. components/script/dom/errorevent.rs -leads to changes in drop method of Drop trait implementation
  4. components/script/dom/audiobuffer.rs -leads to changes in macro_rules! in task.rs
  5. components/script/dom/bindings/settings_stack.rs -leads to changes in Drop trait implementation
  6. components/script/dom/eventtarget.rs -leads to changes in macro_rules! in task.rs
  7. components/script/dom/xrreferencespaceevent.rs -leads to changes in macro_rules! in task.rs
  8. components/script/dom/hashchangeevent.rs -leads to changes in macro_rules! in task.rs

  • There are tests for these changes OR
  • These changes do not require tests because they do not modify functionality

@chickenleaf chickenleaf requested a review from gterzian as a code owner October 14, 2024 16:11
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@jdm jdm added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jdm jdm added this pull request to the merge queue Oct 15, 2024
Merged via the queue into servo:main with commit 1e39787 Oct 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants